Repository navigation
SPTECH-236: Restore booking_customer_accommodation as deprecated - #128
Merged
kingaM merged 1 commit intoOct 5, 2026
Merged
Conversation
The API still returns it alongside booking_pick_up_location; removing it broke partners generating strict clients from the spec. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes correctly restore the removed API contract while clearly marking its replacement.
Review effort: Balanced
Findings: None
What changed in this PR
Restores backward compatibility for clients receiving booking_customer_accommodation, while directing consumers to booking_pick_up_location.
Changes:
- Restores the deprecated booking question and request property.
- Documents the preferred replacement.
| File | Description |
|---|---|
spec/components/schema/option.yaml |
Restores and documents the deprecated question enum value. |
spec/components/schema/bookings.yaml |
Restores the deprecated accommodation answer schema. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
FlaviaC-gyg
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts #120 and marks
booking_customer_accommodationas deprecated in favor ofbooking_pick_up_location. The API still returns it for pickup tours, so its removal broke Check24's generated client.🤖 Generated with Claude Code