Repository navigation
feat(datasetAttributes): always call attributes with context + updated evals - #1518
Merged
Merged
Conversation
…ption based evals
…f-of-more-accurate-description
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nikkikapadia
marked this pull request as ready for review
October 19, 2026 20:12
Base automatically changed from
nikkikapadia/exp-1291-chooses-field-based-off-of-more-accurate-description
to
main
October 20, 2026 15:04
lzhao-sentry
approved these changes
Oct 20, 2026
JoshuaKGoldberg
approved these changes
Oct 20, 2026
| attributeTypes, | ||
| substringMatch, | ||
| query, | ||
| // Always call attributes endpoint with context |
Member
There was a problem hiding this comment.
[Docs] Nit: I think this is implied?
Suggested change
| // Always call attributes endpoint with context |
Member
Author
There was a problem hiding this comment.
true, i'll remove the comment!
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that our evals have shown that the agent will pick the correct attributes and use up to date names, we feel comfortable turning on attribute context in prod. This is a one line change lol.
The rest of the code is just adding eval coverage for logs and metrics. The attribute selection logic is the same across all of these datasets so it's just repetitive but obviously good to have coverage for. Also good to note,
search_eventstool is no longer surfaced; it has been deprecated in favour of dataset hardcoded searches likesearch_traces,search_logs, etc. Luckily they're all just using thesearch_eventstool code under the hood with a locked dataset so all of the attribute logic is still shared amongst all of these tools.Closes EXP-1292