feat(test-celery-queues-module): Migrate to streamed spans - #102
Open
ericapisani wants to merge 1 commit into
Open
feat(test-celery-queues-module): Migrate to streamed spans#102ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
Under trace_lifecycle="stream", start_transaction returns a NoOpSpan and records nothing. Replace the single start_transaction call with sentry_sdk.traces.start_span so the celery queues module demo actually produces a span. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TTtVSwfTGeB9RQzf3Pv8SE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-celery-queues-modulealready hastrace_lifecycle="stream", under whichsentry_sdk.start_transaction(...)returns aNoOpSpanand records nothing.start_transaction(op="function", name="celery-task-started-from-transaction")call inmain.pywithsentry_sdk.traces.start_span(name="celery-task-started-from-transaction", attributes={"sentry.op": "function"}).Test plan
python -m py_compile main.py tasks.pygrep -rn "start_transaction\|sentry_sdk.start_span" test-celery-queues-moduleshows no remaining legacy calls (only the newsentry_sdk.traces.start_span).messaging.*set_datakeys existed in this project's own code to preserve (queues module UI data is set internally byCeleryIntegration).https://claude.ai/code/session_01TTtVSwfTGeB9RQzf3Pv8SE