Repository navigation
feat(lint): run the lint rule review skill on custom oxlint rules - #131080
Draft
JoshuaKGoldberg wants to merge 1 commit into
Draft
JoshuaKGoldberg wants to merge 1 commit into
JoshuaKGoldberg wants to merge 1 commit into
Conversation
Fixes false positives, false negatives, broken autofixes, and over-wide report ranges across the sentry and scraps oxlint plugins, removes dead code, and adds the test cases that expose each.
github-actions
Bot
added
the
Scope: Frontend
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment:
Preview deployment: https://sentry-7y1lvhcs7.sentry.dev |
Contributor
📊 Type Coverage Diff
🔍 3 new type safety issues introducedNon-null assertions (
This is informational only and does not block the PR. |
JoshuaKGoldberg
changed the title
Member
Author
|
@cursor review |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviews every custom rule in the Sentry and Scraps oxlint plugins using https://github.com/JoshuaKGoldberg/lint-rule-review-skill. It found:
The few app files touched are for new violations from rules that now report more (e.g.
export {X as default}), and the newprefer-fake-timershits are recorded as suppressions.Closes DE-1654.