Skip to content

fix(explore): Avoid exponent notation breaks heatmap zoom - #131078

Open
k-fish wants to merge 2 commits into
masterfrom
fix/explore/heatmap-zoom-exponent-bounds
Open

k-fish wants to merge 2 commits into
masterfrom
fix/explore/heatmap-zoom-exponent-bounds

Conversation

@k-fish

@k-fish k-fish commented Nov 13, 2026

Copy link
Copy Markdown
Member

Small numbers were getting turned into e-7 which the filter has no clue what to do with.

Small numbers were getting turned into e-7 which the filter has no clue
what to do with.
@k-fish
k-fish requested a review from a team as a code owner November 13, 2026 16:25
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 13, 2026

@gggritso gggritso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6d43001. Configure here.

* `0.0000001`.
*/
function formatSearchNumber(value: number): string {
return value.toLocaleString(undefined, {useGrouping: false, maximumFractionDigits: 20});

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locale formatting breaks search numbers

High Severity

formatSearchNumber now calls toLocaleString with undefined, so the decimal separator follows the browser locale. Search grammar only accepts ASCII digits and a period, so heatmap zoom writes unparseable bounds (for example a comma) for many users.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 6d43001. Configure here.

@k-fish
k-fish disabled auto-merge November 13, 2026 16:37

This branch was successfully deployed

1 active deployment
Preview — 6d430019 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants