Repository navigation
Conversation
Each half of a stat now declares its own type, text or link, so the value can navigate as well as the label. A link half takes to or externalHref plus an optional onClick, matching the title and metadata items. Tooltips move into the half they explain. A plain string, number or null stays shorthand for a text half. The stat-level type, to, onClick, labelTooltip and valueTooltip props are removed, and the replay and build comparison headers move to the new shape.
Explain which half of a stat to link, how each link is named, and where tooltips live. Clarify that a null value means the data was never collected, not that it is still loading.
Contributor
decision-model-lintervoice
decision-model-linter: 36 calls on 5 files, 120,968 input tokens, $0.0051, model typesafe/jev-1.13-20260917 |
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-8kies3ui4.sentry.dev |
Contributor
Sentry Snapshot Testing
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stat in
EntityHeadercan now link from its value as well as its label. Each half declares its owntype: 'text' | 'link', so a stat can link its label, its value, or both. This unblocks moving the conversation detail header ontoEntityHeader: there the error count itself leads to the errored spans, which today's label-only link can't express.The stat props change shape. Before, the stat as a whole had a
type, linked only through its label, and kept both tooltips at the top level:Now each half carries its own type, destination and tooltip:
toorexternalHrefplus an optionalonClick. That's the sameLinkDestinationthe title and metadata items use, so stat links can now point outside the product too.type,to,onClick,labelTooltipandvalueTooltip. The two callers, the replay details header and the build comparison header, are moved over in the same commit, and their output is unchanged.Accessibility. A value link is named by its own text ("7"), the same way a label link is named by its label. Nothing is renamed to fold in the other half. The neighbouring half sits in the same list item, which is enough context for the link's purpose under WCAG 2.4.4.
Unchanged rules:
Review focus:
items/entityHeaderStat.tsx: the old separate label and value renderers are now oneStatPart.entityHeader.mdx, which now explains when to link which half and tightens whatnullmeans: the data was never collected, never "still loading".