Repository navigation
fix(explore): portal attribute row action menus out of clipping containers - #131068
Draft
JoshuaKGoldberg wants to merge 1 commit into
Draft
JoshuaKGoldberg wants to merge 1 commit into
JoshuaKGoldberg wants to merge 1 commit into
Conversation
…iners The attribute "…" menu rendered inline, so the Explore metrics samples table's scroll container clipped it. Row action menus now always portal, into the surrounding drawer or modal when there is one so they still layer above it. Fixes #130918 Fixes EXP-1466
github-actions
Bot
added
the
Scope: Frontend
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-c3ktjjdgx.sentry.dev |
JoshuaKGoldberg
changed the title
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit ad4ce6f. Configure here.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attribute "…" menu in expanded Explore sample rows rendered inline, so the table's scroll container clipped or hid it. Key/value tree row action menus now always portal, into the surrounding drawer or modal when there is one so they still layer above it.
Changed
Unchanged
Closes #130918. Closes EXP-1466.