Repository navigation
Conversation
Grandfather existing call sites ahead of the S034 lint rule. Refs ISWF-3679
github-actions
Bot
added
the
Scope: Backend
This was referenced Nov 12, 2026
Contributor
Sentry Snapshot Testing
Waiting for base snapshots to finish uploading. This comment will update automatically within ~10 minutes or fail. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Commentary
Adds
# noqa: S034to existing unordered.first()calls insrc/sentry/integrations/, sentry_apps/, identity/, notifications/, pr_metrics/. Comment-only; no behavior change.Stack 2/6 for the S034 lint rule (#130924).
Merge order: getsentry/getsentry#23186 → #130970 → #130972 → #130973 → #130974 → #130975 → #130924 (rule). The rule PR must land last, after every call site is marked.
Refs ISWF-3679