[sentry-junior]

Stacked on #130472. This fixes the pagination bug Cursor Bugbot found during that review (thread). The bug also ships in the published @sentry/api 1.54.0.

Bug

listPage asked each later page for only the rows still missing: per_page = min(100, limit - items.length). listProjects, listTeams and listOrganizations are served by Sentry's OffsetPaginator. Its cursor is <page size>:<page>:<is_prev>, and when per_page doesn't match the cursor's page size, it reads the cursor's window and keeps only the last per_page rows (src/sentry/api/paginator.py). So 100:1:0 with per_page=50 returns rows 150–199, and rows 100–149 are lost. Any limit above 100 dropped rows without an error.

Fix

listPage now walks through the package's existing paginate, which:

• uses one per_page for the whole walk. A fresh walk splits limit evenly: 150 becomes 2 × 75.
• reuses the page size that an offset cursor encodes when resuming, whatever the new limit is.
• returns a cursor that resumes at the first row not returned, including partway through a page.

listPage still validates each page with the schema and still rejects a page with more rows than requested or a repeated cursor. One behavior changes: if a walk reaches MAX_LIST_PAGES, it now returns the rows it has and a resume cursor instead of throwing. Before this change, a stable page size couldn't hit that cap in a normal walk. Now a resumed small-page cursor can, for example 25:1:0 with limit: 5000.

Tests

• A model of OffsetPaginator in core.test.ts. It confirms that 100:1:0 with per_page=50 reads rows 150–199. Then it checks two things:
  • a 150-row walk and its resume return rows 0–299 in order, all with per_page=75;
  • resuming 100:1:0 with limit: 50 returns rows 100–149, then 150–199, both requested with per_page=100.
• The listOrganizations test now expects per_page to stay at 3 on the second request. It was 1, which was the bug.

Package build, typecheck and tests pass (657 tests).

No UI change.

via @BYK.

--

View Session in Sentry

[sentry]

Sentry Snapshot Testing

Name	Added	Removed	Changed	Renamed	Unchanged	Skipped	Status
sentry-frontend sentry-frontend	0	0	0	0	824	0	✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

[BYK]

Can you move this and the next on stack back to sentry-api-schema repo for now as it advanced a lot and it's gonna be easier to get docs aligned first and then move @sentry/api into getsentry/sentry

[sentry-junior]

Moved to getsentry/sentry-api-schema#149.