Repository navigation
feat(seer): Report a missing SCM integration on repo lookups - #130315
Open
joseph-sentry wants to merge 2 commits into
Open
joseph-sentry wants to merge 2 commits into
joseph-sentry wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
Scope: Backend
This was referenced Nov 6, 2026
joseph-sentry
changed the title
Contributor
Sentry Snapshot Testing
|
joseph-sentry
force-pushed
the
joey--seer-report-no-scm-integration
branch
from
November 9, 2026 18:14
8c5a2e6 to
33aa0fb
Compare
joseph-sentry
force-pushed
the
joey--seer-report-no-scm-integration
branch
from
November 9, 2026 19:40
33aa0fb to
99d3056
Compare
Base automatically changed from
joey--seer-repo-lookup-by-url-path
to
master
November 12, 2026 20:04
we want to report back to the caller a new type of error which is when a user has no SCM integrations configured, so this RPC will always fail. This new reporting is opt-in from the caller, this is so Seer can know when a SCM-related tool call fails because the user has not set up SCM at all.
joseph-sentry
force-pushed
the
joey--seer-report-no-scm-integration
branch
from
November 12, 2026 20:04
99d3056 to
94502ad
Compare
joseph-sentry
marked this pull request as ready for review
November 12, 2026 20:45
billyvg
approved these changes
Nov 13, 2026
One active integration is enough to rule out a missing SCM setup, so stop after the first row. Also cover integrations that are disabled for the org or pending deletion, and drop a test that duplicated test_get_repository_definition_not_found.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we want to report back to the caller a new type of error which is when a user has no SCM integrations
configured, so this RPC will always fail. This new reporting is opt-in from the caller, this is so Seer
can know when a SCM-related tool call fails because the user has not set up SCM at all.