Repository navigation
ref(apidocs): Record S025-S028 facts for every function and the calls they make - #130259
Merged
akhilp117 merged 4 commits intoNov 13, 2026
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8e62754. Configure here.
DominikB2014
approved these changes
Nov 10, 2026
… the end of the module walk instead of at the node
_functions keeps one ctx per scope, so a public method defined twice (an if/else def, or @overload then the real def) lost the earlier definition's findings. Report from a list of every ctx in file order and keep the dict for name lookups only.
akhilp117
force-pushed
the
akhilpindiprolu/eng-8951-fix-s026-to-catch-raw-reads-being-passed-into-helpers
branch
from
November 12, 2026 16:33
c9540fc to
cc98e57
Compare
DominikB2014
approved these changes
Nov 13, 2026
akhilp117
deleted the
akhilpindiprolu/eng-8951-fix-s026-to-catch-raw-reads-being-passed-into-helpers
branch
November 13, 2026 15:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is part 1 of 2 for ENG-8951 which checks request payloads passed to same-file helpers. The S025-S028 input rules only look inside a public endpoint method, so a raw read or a serializer inside a helper the method calls is never reported. This PR is just the groundwork. It changes no output.
_InputCtx), not just public HTTP methods. Each ctx is stored by scope, likeMyEndpoint.getorbuild_query@extend_schemacalls aren't counted as part of the functionhelper(),self.helper()andsuper().helper(), which arguments carry request input, and whether the call has*argsor**kwargsdef helper()or using@overloadthen the real def) is reported once per definition._functions(which is a dict of scope : the functions ctx) is only used for looking a function up by name, and reporting goes through every ctx in file orderNothing reads the recorded calls yet. #130267 follows same-file helpers and reports their reads under the public method