poc: capture screenshots with error envelope - #2835
Draft
bitsandfoxes wants to merge 1 commit into
Draft
Conversation
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- capture screenshots with error envelope ([#2835](https://github.com/getsentry/sentry-unity/pull/2835))If none of the above apply, you can opt out of this check by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactor to see what it would look like to capture a screenshot at the time of the error instead of sending it at "End Of Frame".
This would also be more technically correct, since with the current implementation the screenshot shows the state of the game AFTER the error happened.
Instead of waiting for
EndOfFramewe would keep a screenshot around based on a configurable cadence, and attach that to the error at the time of the error.This would do a couple of things: