chore(deps): update Native SDK to v0.16.5 - #2826
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
bruno-garcia
force-pushed
the
deps/modules/sentry-native/0.16.5
branch
from
September 2, 2026 03:03
7bd4e9a to
2f86a68
Compare
| @@ -1 +1 @@ | |||
| Subproject commit 22e1073a32e940b190e048890ede26c1dd1db3ef | |||
| Subproject commit 1c935e87ce24d4697ac4710278269237be17e006 | |||
There was a problem hiding this comment.
Bug: Updating sentry-native to v0.16.5 causes EnableLogs and EnableMetrics settings to be ignored for logs/metrics generated internally by the native SDK, as the underlying native functions are now no-ops.
Severity: MEDIUM
Suggested Fix
Remove the calls to the deprecated sentry_options_set_enable_logs and sentry_options_set_enable_metrics functions. To restore the intended filtering behavior, implement the new recommended native SDK mechanism by using sentry_options_set_before_send_log and sentry_options_set_before_send_metric to check the EnableLogs and EnableMetrics settings and discard events accordingly at the native level.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: modules/sentry-native#L1
Potential issue: The update to `sentry-native` v0.16.5 introduces a behavioral
regression. The native functions `sentry_options_set_enable_logs` and
`sentry_options_set_enable_metrics`, which are called by the C# bridge, are now
deprecated and have no effect. While the C# layer has its own guards that filter most
logs and metrics based on the `EnableLogs` and `EnableMetrics` settings, this does not
apply to any logs or metrics generated internally by the native SDK itself. As a result,
these internal native-layer events will be sent even when the user has disabled them in
the options, leading to unintended data transmission.
Did we get this right? 👍 / 👎 to inform future reviews.
bruno-garcia
force-pushed
the
deps/modules/sentry-native/0.16.5
branch
from
September 3, 2026 04:09
2f86a68 to
a1f83cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps modules/sentry-native from 0.16.4 to 0.16.5.
Auto-generated by a dependency updater.
Changelog
0.16.5
Important behavior changes:
sentry_options_set_enable_logsandsentry_options_set_enable_metricsno longer have any effect. The corresponding getters always return true.Features:
sentry_crashfor deliberately crashing the current process to test its crash reporting configuration. (#2013)sentry_options_set_thread_stackwalk_modeto limit client-side stackwalking to the crashed thread, which shortens crash processing for applications with a high thread count. (#2026)sentry_value_foreach_valueandsentry_value_foreach_key_valuefor iterating lists and objects. (#2032)Fixes:
Other changes: