Repository navigation
ci(ruff): Enable RUF100 for unused noqa directives - #8282
Conversation
Remove noqa comments that no longer suppress anything, most of them for pep8-naming and bugbear codes left over from the flake8 plugins, which ruff doesn't enable here. Co-Authored-By: Ivana Kellyer <131587164+sentrivana@users.noreply.github.com>
|
@sentry-junior Regarding "Open question: should the flake8-era N8xx/B0xx comments be deleted, or kept as markers in case those rule groups get turned on later?" They should be deleted. If you haven't deleted them yet, do it in this PR please |
Coverage Results 📊✅ 139266 passed | ⏭️ 7853 skipped | Total: 147119 | Pass Rate: 94.66% | Execution Time: 451m 4s 📊 Comparison with Base Branch
✨ Test counts unchanged from base. All tests are passing successfully. ✅ Patch coverage is 100.00% (40 of 40 changed executable lines covered; target 80%). Changed files with executable lines (10)
Coverage diff@@ Coverage Diff @@
## master #8282 +/-##
==========================================
- Coverage 90.24% 90.21% -0.03%
==========================================
Files 203 203 —
Tracked lines 27335 27335 —
Branches 10246 10246 —
==========================================
- Hits 24668 24660 -8
- Misses 2667 2675 +8
- Partials 1558 1559 +1Generated by Coverage Action |
Drop the N806 marker inside parse_version's verbose regex (it was a regex comment, so the pattern is unchanged), the B014/N812/N804 ignores, and the note about B and N rules. Neither rule group is selected.
|
Removed. The first commit already dropped the flake8-era
No |
### Description Turns on ruff's `T20`, which flags `print()` and `pprint()` calls. The SDK runs inside users' apps, so a stray debug `print()` ends up in their output; we should log through the SDK logger instead. `sentry_sdk` has none today, so this is config only. Tests and scripts are excluded via `per-file-ignores` because they print on purpose. Each ruff-rule PR (#8282, #8283, #8285, #8286, #8287) targets `master` on its own. They all add a line to the same `select` list in `pyproject.toml`, so whichever merges first leaves the others with a small conflict there to resolve. <!-- junior-request-attribution:start --> via @sentrivana. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC0CAA8NNBE3%3A1794392136.309249 --> -- [View Session](https://junior-prod.sentry.dev/conversations/slack%3AC0CAA8NNBE3%3A1794392136.309249) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0CAA8NNBE3%3A1794392136.309249/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Ivana Kellyer <131587164+sentrivana@users.noreply.github.com>
# Conflicts: # pyproject.toml
### Description Turns on ruff's `PT011`, which flags `pytest.raises()` with a broad exception type such as `ValueError` or `Exception` and no `match=`. Without `match=`, a test can pass on the wrong error. The 27 existing offenders are fixed rather than ignored. Most get a `match=` with the expected message. Two get a narrower exception type (`CannotSendRequest` in the httplib test, `ZeroDivisionError` in a skipped celery test), and `test_get_error_message` no longer misuses `pytest.raises()` as an attribute holder. Each ruff-rule PR (#8282, #8283, #8285, #8286, #8287) targets `master` on its own. They all add a line to the same `select` list in `pyproject.toml`, so whichever merges first leaves the others with a small conflict there to resolve. <!-- junior-request-attribution:start --> via @sentrivana. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC0CAA8NNBE3%3A1794392136.309249 --> -- [View Session](https://junior-prod.sentry.dev/conversations/slack%3AC0CAA8NNBE3%3A1794392136.309249) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0CAA8NNBE3%3A1794392136.309249/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Ivana Kellyer <131587164+sentrivana@users.noreply.github.com> Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
# Conflicts: # pyproject.toml # tests/integrations/celery/test_celery.py # tests/integrations/stdlib/test_httplib.py
### Description Turns on ruff's `PLC0415`, which flags imports that aren't at the top level of the file. This enforces the top-level-imports guideline in `AGENTS.md`, which reviewers currently check by hand. The rule covers `sentry_sdk` only; tests are excluded. 16 existing inline imports didn't need to be inline, so they're now at the top level or in an existing module-level import. The other 89 are intentional (optional deps, version checks, circular imports, Django) and get a `# noqa: PLC0415` comment, so any new inline import needs the same explicit marker. Each ruff-rule PR (#8282, #8283, #8285, #8286, #8287) targets `master` on its own. They all add a line to the same `select` list in `pyproject.toml`, so whichever merges first leaves the others with a small conflict there to resolve. <!-- junior-request-attribution:start --> via @sentrivana. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC0CAA8NNBE3%3A1794392136.309249 --> -- [View Session](https://junior-prod.sentry.dev/conversations/slack%3AC0CAA8NNBE3%3A1794392136.309249) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0CAA8NNBE3%3A1794392136.309249/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Ivana Kellyer <131587164+sentrivana@users.noreply.github.com>
Description
Turns on ruff's
RUF100, which flagsnoqacomments that don't suppress anything, so stale suppressions can't pile up. It also removes the 189 that exist today, most of themN8xx,E231andB0xxcodes left over from the flake8 plugins, which ruff doesn't enable here. The leftoverB/Nignores and notes inpyproject.tomlgo too. Only comments and config change; some lines got joined byruff formatonce their comments were gone.Each ruff-rule PR (#8282, #8283, #8285, #8286, #8287) targets
masteron its own. They all add a line to the sameselectlist inpyproject.toml, so whichever merges first leaves the others with a small conflict there to resolve.via @sentrivana.
--
View Session [Sentry]