Skip to content

ci: Add typos spell check - #8279

Merged
sentrivana merged 3 commits into
masterfrom
ci/add-typos
Nov 16, 2026
Merged

sentrivana merged 3 commits into
masterfrom
ci/add-typos

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

This one is more for humans rather than agents, but still nice to have.

Description

Adds typos to the CI lint job and to pre-commit, so misspellings get caught on the PR and we don't need cleanup passes like #8241. It comes in through the dev dependency group, like ruff.

_typos.toml allowlists the spellings that #8241 kept on purpose (baGGage, the deprecat regex, chunked test strings), plus GAE and certifi. It also skips CHANGELOG.md, since those are historical release notes.

A couple of spellings get fixed instead of allowlisted:

  • The MIGRATION_GUIDE.md entry about the MetricsAggregator method rename is reworded so it no longer spells out the old misspelled name.
  • The aiohttp test test_tracing_unparseable_url is renamed to test_tracing_unparsable_url.

CI also scans hidden files, so .github/ gets checked the same way the pre-commit hook checks it.

typos has fewer false positives on this repo than codespell, which flags names like checkin and dependant.

via @sentrivana.

--

View Session [Sentry]

Run typos in the lint job and as a pre-commit hook so misspellings get
caught on the PR instead of in a cleanup pass. The config allowlists
the intentional spellings left alone in #8241.

Co-Authored-By: Ivana Kellyer <131587164+sentrivana@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 139228 passed | ⏭️ 7857 skipped | Total: 147085 | Pass Rate: 94.66% | Execution Time: 459m 38s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ Test counts unchanged from base.

All tests are passing successfully.

✅ Patch coverage is 100.00% (no changed executable lines found; target 80%).
Project statement coverage is 90.21% (down 0.01 percentage points from base (ae73d8c) to head (75063ea)).

Coverage diff
@@            Coverage Diff             @@
##        master     #8279       +/-##
==========================================
- Coverage    90.22%    90.21%    -0.01%
==========================================
  Files          203       203         —
  Tracked lines     27335     27327        -8
  Branches     10246     10246         —
==========================================
- Hits         24663     24652       -11
- Misses        2672      2675        +3
- Partials      1556      1559        +3

Generated by Coverage Action

sentry-junior Bot and others added 2 commits November 16, 2026 13:31
Co-Authored-By: Ivana Kellyer <131587164+sentrivana@users.noreply.github.com>
Co-Authored-By: Ivana Kellyer <131587164+sentrivana@users.noreply.github.com>
@sentrivana
sentrivana marked this pull request as ready for review November 16, 2026 13:35
@sentrivana
sentrivana requested a review from a team as a code owner November 16, 2026 13:36
@sentry-junior
sentry-junior Bot requested a review from sentrivana November 16, 2026 13:36
@sentry-junior
sentry-junior Bot added this pull request to stack #8299 November 16, 2026 13:38
Comment thread MIGRATION_GUIDE.md Resolved
@sentrivana
sentrivana enabled stacked auto-merge (squash) November 16, 2026 13:44
@sentrivana
sentrivana merged commit e9c62e5 into master Nov 16, 2026
175 checks passed
@sentrivana
sentrivana deleted the ci/add-typos branch November 16, 2026 13:45
@linear-code

linear-code Bot commented Nov 17, 2026

Copy link
Copy Markdown

PY-3085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants