Skip to content

feat(sqlalchemy): Add more db system names for span data - #7329

Open
ericapisani wants to merge 1 commit into
masterfrom
py-2531-add-more-db-names
Open

feat(sqlalchemy): Add more db system names for span data#7329
ericapisani wants to merge 1 commit into
masterfrom
py-2531-add-more-db-names

Conversation

@ericapisani

Copy link
Copy Markdown
Member

Recognize snowflake, clickhouse, mongodb, and cockroachdb as db.system values when inferring the database system from the SQLAlchemy dialect name.

Refs PY-2531
Refs #6573

Recognize snowflake, clickhouse, mongodb, and cockroachdb as db.system
values when inferring the database system from the SQLAlchemy dialect name.

Refs PY-2531
Refs #6573
@ericapisani
ericapisani requested a review from a team as a code owner September 1, 2026 18:15
@linear-code

linear-code Bot commented Sep 1, 2026

Copy link
Copy Markdown

PY-2531

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

125599 passed | ⏭️ 6763 skipped | Total: 132362 | Pass Rate: 94.89% | Execution Time: 457m 37s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +692
Passed Tests 📈 +696
Failed Tests 📉 -4
Skipped Tests

➖ Removed Tests (4)

View removed tests
  • test_cache_spans_decorator[True]
    • File: tests.integrations.django.test_cache_module
  • test_continuous_profiler_auto_start_and_stop_sampled[experiment-thread]
    • File: tests.profiler.test_continuous_profiler
  • test_continuous_profiler_auto_start_and_stop_sampled[non-experiment-gevent]
    • File: tests.profiler.test_continuous_profiler
  • test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[experiment-thread]
    • File: tests.profiler.test_continuous_profiler

All tests are passing successfully.

❌ Patch coverage is 0.00%. Project has 2504 uncovered lines.
❌ Project coverage is 90.24%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/sqlalchemy.py 0.00% ⚠️ 8 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    90.27%    90.24%    -0.03%
==========================================
  Files          193       193         —
  Lines        25649     25657        +8
  Branches      9454      9462        +8
==========================================
+ Hits         23153     23153         —
- Misses        2496      2504        +8
- Partials      1443      1443         —

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant