feat(sqlalchemy): Add more db system names for span data - #7329
Open
ericapisani wants to merge 1 commit into
Open
feat(sqlalchemy): Add more db system names for span data#7329ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
Recognize snowflake, clickhouse, mongodb, and cockroachdb as db.system values when inferring the database system from the SQLAlchemy dialect name. Refs PY-2531 Refs #6573
Contributor
Codecov Results 📊✅ 125599 passed | ⏭️ 6763 skipped | Total: 132362 | Pass Rate: 94.89% | Execution Time: 457m 37s 📊 Comparison with Base Branch
➖ Removed Tests (4)View removed tests
All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 2504 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 90.27% 90.24% -0.03%
==========================================
Files 193 193 —
Lines 25649 25657 +8
Branches 9454 9462 +8
==========================================
+ Hits 23153 23153 —
- Misses 2496 2504 +8
- Partials 1443 1443 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognize snowflake, clickhouse, mongodb, and cockroachdb as db.system values when inferring the database system from the SQLAlchemy dialect name.
Refs PY-2531
Refs #6573