ref(pydantic-ai): Use hooks.on.model_request to replace individual hooks - #7327
Open
alexander-alderman-webb wants to merge 1 commit into
Open
ref(pydantic-ai): Use hooks.on.model_request to replace individual hooks#7327alexander-alderman-webb wants to merge 1 commit into
hooks.on.model_request to replace individual hooks#7327alexander-alderman-webb wants to merge 1 commit into
Conversation
Contributor
Codecov Results 📊✅ 121930 passed | ⏭️ 6762 skipped | Total: 128692 | Pass Rate: 94.75% | Execution Time: 415m 5s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2484 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.27% 90.29% +0.02%
==========================================
Files 193 193 —
Lines 25649 25580 -69
Branches 9454 9418 -36
==========================================
+ Hits 23153 23096 -57
- Misses 2496 2484 -12
- Partials 1445 1428 -17Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Noticed that we can simplify while working on the major.
Use
hooks.on.model_requestto replace all ofhooks.on.before_model_request,hooks.on.model_request_errorandhooks.on.after_model_request.Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)