Skip to content

feat(clickhouse_driver): Set breadcrumbs in the streaming trace lifecycle - #7325

Open
alexander-alderman-webb wants to merge 14 commits into
masterfrom
webb/clickhouse_driver/breadcrumbs
Open

feat(clickhouse_driver): Set breadcrumbs in the streaming trace lifecycle#7325
alexander-alderman-webb wants to merge 14 commits into
masterfrom
webb/clickhouse_driver/breadcrumbs

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Description

This is analogous to adding breadcrumbs to Redis and HTTP client integrations, so that breadcrumbs are not lost when users enable the streaming trace lifecycle.

Set the (non-deprected) attributes used by streamed spans as breadcrumbs when the streaming trace lifecycle is enabled.

Adds tests with the _span_streaming suffix based on existing tests.

Issues

Closes #7317

Reminders

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 1, 2026 09:42
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 1, 2026 09:42
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as draft September 1, 2026 09:43

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6abe189. Configure here.

Comment thread sentry_sdk/integrations/clickhouse_driver.py Outdated
Comment thread sentry_sdk/integrations/clickhouse_driver.py Outdated
Comment thread sentry_sdk/integrations/clickhouse_driver.py
Comment thread sentry_sdk/integrations/clickhouse_driver.py Outdated
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

121335 passed | ❌ 1 failed | ⏭️ 6756 skipped | Total: 128092 | Pass Rate: 94.72% | Execution Time: 430m 47s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +22691
Passed Tests 📈 +22413
Failed Tests 📈 +1
Skipped Tests 📈 +277

➕ New Tests (1)

View new tests
  • test_cache_spans_decorator[True]
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

❌ Failed Tests

test_cache_spans_decorator[True]

File: tests.integrations.django.test_cache_module
Suite: py3.10-django-v5.2.17
Error: tests/integrations/django/test_cache_module.py:385: in test_cache_spans_decorator assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:385: in test_cache_spans_decorator
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

✅ Patch coverage is 100.00%. Project has 2490 uncovered lines.
✅ Project coverage is 90.28%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.28%    90.28%        —%
==========================================
  Files          193       193         —
  Lines        25621     25630        +9
  Branches      9438      9442        +4
==========================================
+ Hits         23132     23140        +8
- Misses        2489      2490        +1
- Partials      1436      1434        -2

Generated by Codecov Action

Comment thread sentry_sdk/integrations/clickhouse_driver.py Outdated
Comment thread sentry_sdk/integrations/clickhouse_driver.py
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 1, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set breadcrumbs for clickhouse_driver

1 participant