Skip to content

feat(billing): Add can_admin_product_trial to package line items #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dashed wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(billing): Add can_admin_product_trial to package line items #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df0277d
feat(billing): Add can_admin_product_trial to package line items
dashed Nov 13, 2026
1c6faa2
docs(billing): Set at most one product trial flag per line item
dashed Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions proto/sentry_protos/billing/v1/services/package/v1/package.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ message LineItemConfig {
// Whether this LineItem is eligible for a product trial.
bool can_product_trial = 12;

// Whether staff can start a product trial of this LineItem, though customers cannot (ie Size Analysis).
// Staff can also start a product trial of any LineItem with can_product_trial set.
// Set at most one of can_product_trial and can_admin_product_trial.
bool can_admin_product_trial = 14;

sentry_protos.billing.v1.common.v1.BillingType billing_type = 13;
}

Expand Down Expand Up @@ -75,6 +80,11 @@ message SharedLineItemPool {

// Whether this LineItem is eligible for a product trial.
bool can_product_trial = 11;

// Whether staff can start a product trial of this pool, though customers cannot.
// Staff can also start a product trial of any pool with can_product_trial set.
// Set at most one of can_product_trial and can_admin_product_trial.
bool can_admin_product_trial = 12;
}

// Non-volume feature limits tied to a package tier (dashboards, metric
Expand Down
10 changes: 10 additions & 0 deletions rust/src/sentry_protos.billing.v1.services.package.v1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ pub struct LineItemConfig {
/// Whether this LineItem is eligible for a product trial.
#[prost(bool, tag = "12")]
pub can_product_trial: bool,
/// Whether staff can start a product trial of this LineItem, though customers cannot (ie Size Analysis).
/// Staff can also start a product trial of any LineItem with can_product_trial set.
/// Set at most one of can_product_trial and can_admin_product_trial.
#[prost(bool, tag = "14")]
pub can_admin_product_trial: bool,
#[prost(enumeration = "super::super::super::common::v1::BillingType", tag = "13")]
pub billing_type: i32,
/// how many of this lineitem are included in the package, the customer can reserve more on their contract
Expand Down Expand Up @@ -107,6 +112,11 @@ pub struct SharedLineItemPool {
/// Whether this LineItem is eligible for a product trial.
#[prost(bool, tag = "11")]
pub can_product_trial: bool,
/// Whether staff can start a product trial of this pool, though customers cannot.
/// Staff can also start a product trial of any pool with can_product_trial set.
/// Set at most one of can_product_trial and can_admin_product_trial.
#[prost(bool, tag = "12")]
pub can_admin_product_trial: bool,
/// How many units are available for a PackageConfig during a subscription trial? For packages that are not eligible for trials,
/// this field will be unset for all line items.
#[prost(oneof = "shared_line_item_pool::TrialUnits", tags = "9, 10")]
Expand Down
Loading