Repository navigation
feat(billing): Add ResetProductTrial engagement protos - #519
Merged
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
armcknight
approved these changes
Nov 12, 2026
Request and response messages for an EngagementService method that clears an organization's ended product trials for one line item, so staff can let it start that product trial again, as Allow Trial does on legacy. Refs REVENG-724
dashed
force-pushed
the
aleal/billing-reset-product-trial
branch
from
November 12, 2026 21:32
41d8641 to
5bb1df2
Compare
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ResetProductTrialRequestandResetProductTrialResponse, for anEngagementServicemethod that lets an organization start a product trial again after it has used it.Why
On legacy billing, staff press Allow Trial on the admin page to reset a used product trial. They have done it about 600 times. The billing platform has no way to do this, so the same request returns a 500 for a migrated organization (REVENG-724).
ResetSubscriptionTrial(#481) does this for subscription trials only.What
New file
billing/v1/services/engagement/v1/endpoint_reset_product_trial.proto. It isendpoint_reset_subscription_trial.protowith the line item added.ResetProductTrialRequestorganization_idline_item_uidResetProductTrialResponseresetCompatibility
New messages only. Nothing that exists changes.
Consumer
getsentry/getsentry#23127 uses it for the admin Allow Trial action. It needs a release that includes this change.
Refs REVENG-724