fix(v10/bundler-plugins): Stamp debug IDs onto emitted source maps when disable-upload is set - #24332
Merged
Merged
Conversation
…en `disable-upload` is set Backport of: #23754
Contributor
size-limit report 📦
|
Load Rolldown only inside its version-gated test so Node 18 can collect and run the remaining Rollup cases. Co-Authored-By: OpenAI GPT-6 <codex@openai.com>
msonnb
marked this pull request as ready for review
September 11, 2026 11:30
chargome
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #23754
Differences to the original PR
packages/bundler-plugins/src/core/debug-id-upload.ts: included the existingbundleHasInlineSourceMaphelper fromdevelop, becausev10does not have it and the new stamping logic requires it.packages/bundler-plugins/test/core/debug-id-upload.test.ts: added the shared debug-ID snippet and logger helpers directly, rather than moving them out of the upload tests, because those earlier tests are absent onv10. All tests introduced by fix(bundler-plugins): Stamp debug IDs onto emitted source maps whendisable-uploadis set #23754 are preserved.packages/bundler-plugins/test/rollup/disable-upload.test.ts: skip only the Rolldown/Vite case on Node 18 and import Rolldown inside that test. Rolldown requires newer Node APIs, so a top-level import prevented all five Rollup tests from loading on Node 18. The other four cases still run there, and newer CI runtimes retain the Rolldown coverage.