feat(deno): Add conversationIdIntegration to default integrations - #24299
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7a6643c. Configure here.
| functionToStringIntegration(), | ||
| linkedErrorsIntegration(), | ||
| dedupeIntegration(), | ||
| conversationIdIntegration(), |
There was a problem hiding this comment.
Feat PR lacks integration test
Low Severity
This feat PR does not include an integration or E2E test for the new default. Flagged because the project's testing conventions require at least one integration or E2E test on feat PRs. Existing sdk.test.ts already asserts other default integrations, and the user-visible behavior is conversation IDs being stamped onto gen_ai spans.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 7a6643c. Configure here.
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
September 10, 2026 14:13
mydea
requested review from
a team,
JPeer264,
RulaKhaled and
isaacs
and removed request for
a team
September 10, 2026 14:13
mydea
added a commit
that referenced
this pull request
Sep 11, 2026
…4310) The size-limit GitHub action was comparing PRs against a **stale develop baseline** — e.g. #24299 (run at 12:10 on Sep 10) picked a baseline build from Sep 8, two days and many commits behind the tip, **without** the "not the latest" warning banner. _Root cause_ Baseline resolution drove off `listWorkflowRuns` filtered by `branch` + `event=push`. That listing is backed by an eventually-consistent index that can omit or reorder recent runs. At the time #24299 ran, that index returned the Sep 8 run as the first (newest) result even though six completed Sep 10 develop runs already carried the `size-limit-action` artifact — so the action took the Sep 8 build and stopped. ## Solution Now, we pick the latest commits from git, and fetch the artifacts for their CI runs. This should always be correct and not eventually consistent. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Deno SDK was the only server-side SDK not registering
conversationIdIntegrationby default. This adds it togetDefaultIntegrations, bringing Deno in line with the browser, node, cloudflare, and vercel-edge SDKs, so conversation ids set viaSentry.setConversationId()are stamped onto spans out of the box.Placed in the "Common" group alongside the other cross-runtime integrations, matching where node registers it.
🤖 Generated with Claude Code