fix(server-utils): Sanitize PostgreSQL dollar-quoted strings in `db.q… - #24248
Merged
Conversation
s1gr1d
requested review from
Lms24,
logaretm and
stephanie-anderson
and removed request for
a team and
stephanie-anderson
September 9, 2026 13:15
Contributor
size-limit report 📦
|
s1gr1d
added this pull request to stack #24251
September 9, 2026 13:33
s1gr1d
requested review from
mydea and
nicohrubec
and removed request for
a team
September 9, 2026 15:25
s1gr1d
force-pushed
the
sig/db-tests-improvements
branch
from
September 9, 2026 15:25
f6d1a96 to
1fd6184
Compare
s1gr1d
added a commit
that referenced
this pull request
Sep 10, 2026
Follow-up for #24248, which left the SQL Server case open. The sanitizer had no state for T-SQL `[bracketed]` identifiers, so a quote inside one desynced it: `SELECT * FROM [dbo].[user's] WHERE email = 'jane@example.com'` leaked the address into `db.query.text` and `db.query.summary`. There is now an `mssql` dialect that reads `[...]` as an identifier, and tedious, knex and Prisma route to it through a new `toSqlDialect()` helper. Two older leaks turned up while testing it: an identifier run ending in an escaped closer (`[a]]`, `""`) was treated as closed and copied out whole, and T-SQL money literals (`$1000`) survived because the integer pattern protects PostgreSQL `$n` placeholders. Known limit: SQLite accepts `[...]` too, but shares the `standard` dialect with PostgreSQL, where reading brackets as identifiers would keep `ARRAY['secret']` raw. Sources: - T-SQL identifiers: https://learn.microsoft.com/en-us/sql/relational-databases/databases/database-identifiers - T-SQL constants (money, `N'...'`): https://learn.microsoft.com/en-us/sql/t-sql/data-types/constants-transact-sql - SQLite double-quoted strings: https://sqlite.org/quirks.html#double_quoted_string_literals_are_accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #24089 to add some more sanitization tests.
The tests found a leak.
sanitizeSqlQueryhandles'...'but not PostgreSQL's$$...$$, soWHERE email = $$jane@example.com$$went out raw andgetSqlQuerySummaryread the tail as a table name. It now takes a dollar-quoted body as one unit, forstandardonly, since MySQL has no dollar quoting and allows$inidentifiers.
Also fixed:
N'Jane'left itsNbehind, and SQLite?1became??.SQL Server
[bracketed]identifiers containing a quote still desync the scanner. That needs anmssqldialect, so it gets its own PR.Sources: