feat(angular): Emit low cardinality TraceMethod span name and preserve description - #24239
Open
Lms24 wants to merge 6 commits into
Open
feat(angular): Emit low cardinality TraceMethod span name and preserve description#24239Lms24 wants to merge 6 commits into
TraceMethod span name and preserve description#24239Lms24 wants to merge 6 commits into
Conversation
Lms24
requested review from
mydea and
nicohrubec
and removed request for
a team
September 9, 2026 11:05
Lms24
changed the title
TraceMethod span name and preserve description
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c0dbb63. Configure here.
Contributor
size-limit report 📦
|
nicohrubec
approved these changes
Sep 10, 2026
nicohrubec
left a comment
nicohrubec
left a comment
Member
There was a problem hiding this comment.
not sure if this assertion was dropped on purpose, but other than that lgtm
| attributes: expect.objectContaining({ | ||
| 'sentry.op': { type: 'string', value: 'function' }, | ||
| 'sentry.origin': { type: 'string', value: 'auto.ui.angular.trace_method_decorator' }, | ||
| 'code.function.name': { type: 'string', value: 'ngAfterViewInit' }, |
Member
There was a problem hiding this comment.
q/l: why is this gone? the implementation falls back to the value we used before so iiuc the value should still be there
Member
Author
There was a problem hiding this comment.
added it back. I removed the logic to set this previously because I thought it was weird that span description was unnamed but we had this attribute. I then walked back on this to keep as much information as possible but forgot to read the assertion 😅
Member
Author
There was a problem hiding this comment.
This is only an issue if users don't pass a name to the decorator, which is generally what we recommend to avoid mangled/minified function names
| attributes: expect.objectContaining({ | ||
| 'sentry.op': { type: 'string', value: 'function' }, | ||
| 'sentry.origin': { type: 'string', value: 'auto.ui.angular.trace_method_decorator' }, | ||
| 'code.function.name': { type: 'string', value: 'ngOnInit' }, |
Member
There was a problem hiding this comment.
for instance here we keep the assertion
Lms24
enabled auto-merge (squash)
September 10, 2026 10:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts the
functionspan name for@TraceMethoddecorator spans in the Angular SDK:sentry.descriptionattribute. We can't model the special case we had here previously with convention description inference rules, so we need to override inference by directly setting this attribute.ref #23954