fix(v10/nextjs): Keep the Pages Router runtime out of App Router client bundles - #24223
Merged
Merged
Conversation
…nt bundles Backport of: #24188
Contributor
size-limit report 📦
|
chargome
marked this pull request as ready for review
September 9, 2026 08:39
chargome
requested review from
mydea and
nicohrubec
and removed request for
a team
September 9, 2026 08:39
Lms24
approved these changes
Sep 9, 2026
nicohrubec
approved these changes
Sep 9, 2026
chargome
deleted the
chargome/fix/v10-nextjs-static-pages-router-split
branch
September 9, 2026 08:45
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #24188
Differences to the original PR
packages/nextjs/src/client/routing/pagesRouterNavigationInstrumentation.ts: uses v10'sSEMANTIC_ATTRIBUTE_SENTRY_OP/SEMANTIC_ATTRIBUTE_SENTRY_SOURCEand the plain route/URL span name; v10 has no@sentry/conventions/op,SENTRY_SEGMENT_NAME_SOURCE, or span-streaming name fallback. The__BUILD_MANIFEST-typedglobalObjectmoved here with the route matching code.packages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts: keeps v10's pageload code (browserPerformanceTimeOriginstart time, v10 attribute constants); only the navigation half and thenext/routerimport were removed.dev-packages/e2e-tests/test-applications/nextjs-16/tests/build-output.test.ts: new file on v10 containing only the bundle assertion; the absolute-path-imports test fromdevelopdepends on a@sentry-internal/test-utilshelper that does not exist on v10.