test(node): Port fastify, koa, hapi, hono and lru-memoizer suites to span streaming - #24194
Open
chargome wants to merge 2 commits into
Open
test(node): Port fastify, koa, hapi, hono and lru-memoizer suites to span streaming#24194chargome wants to merge 2 commits into
chargome wants to merge 2 commits into
Conversation
…span streaming Rewrite the transaction assertions against span v2 containers and fold the env-gated streamed naming tests for fastify and hapi into the main tests. Fixes #24136 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0e24249. Configure here.
chargome
marked this pull request as ready for review
September 11, 2026 10:21
chargome
requested review from
JPeer264 and
mydea
and removed request for
a team
September 11, 2026 10:21
Span streaming is the default, so the pin is redundant. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the fastify, koa, hapi, hono-sdk and lru-memoizer suites against span v2 containers and folds the env-gated streamed naming tests into the main tests; child-span assertions rely on a request's spans flushing in one envelope. Fixes #24136