test(e2e): Port the TanStack Start Cloudflare E2E app to span streaming - #24173
Merged
RulaKhaled merged 4 commits intoSep 11, 2026
Merged
Conversation
Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Contributor
size-limit report 📦
|
Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
RulaKhaled
marked this pull request as ready for review
September 8, 2026 12:15
nicohrubec
reviewed
Sep 10, 2026
| attributes: expect.objectContaining({ | ||
| 'sentry.op': { type: 'string', value: 'function' }, | ||
| 'sentry.origin': { type: 'string', value: 'auto.function.tanstackstart.server' }, | ||
| 'tanstackstart.function.filename': { type: 'string', value: 'src/routes/test-serverFn.tsx' }, |
Member
There was a problem hiding this comment.
was the assertion on tanstackstart.function.id dropped on purpose?
Collaborator
Author
There was a problem hiding this comment.
this was accidentally dropped, thanks for catching!
| attributes: expect.objectContaining({ | ||
| 'sentry.op': { type: 'string', value: 'function' }, | ||
| 'sentry.origin': { type: 'string', value: 'auto.function.tanstackstart.server' }, | ||
| 'tanstackstart.function.filename': { type: 'string', value: 'src/routes/test-serverFn.tsx' }, |
… spans
The streaming port had to swap the exact `data` match for
`expect.objectContaining`, since streamed spans carry more attributes and
wrap each value as `{ type, value }`. The three attributes with concrete
expected values were carried over, but `tanstackstart.function.id` was
dropped along the way.
`expect.any(String)` was still doing work there: it asserted presence, and
under `objectContaining` the attribute disappearing would otherwise pass
silently. Restore it in both server function specs.
Verified locally against the built worker: full app suite passes (11), and
swapping the matcher for a literal sentinel fails both specs, confirming the
attribute is really emitted on the streamed span.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WQM2HA4xdirxTSCtQvDRP6
nicohrubec
approved these changes
Sep 11, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
RulaKhaled
deleted the
rolaabuhasna/js-3489/tanstackstart-react-cloudflare
branch
September 11, 2026 08:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
traceLifecycle: 'static'pin from the TanStack Start Cloudflare E2E app and rewrites its server, pageload, and SSR-error specs onto streamed spans.Why
This app is not a copy of the Node TanStack Start suite: the client SDK is
@sentry/browser, server origin isauto.http.cloudflare, and there is no middleware, route-param, tunnel, or db-driver coverage. Cloudflarehttp.servernames are also method-only unless the source is alreadyroute, so waits matchurl.path.Part of #23805