test(e2e): Port the Vue TanStack Router E2E app to span streaming - #24170
Merged
Conversation
Web vitals stay off the streamed pageload span, so that assertion is dropped. Redirect and follow-up navigation specs still match the parameterized target route. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Contributor
size-limit report 📦
|
Lms24
approved these changes
Sep 11, 2026
| transaction_info: { | ||
| source: 'route', | ||
| }, | ||
| measurements: expect.objectContaining({ |
Member
There was a problem hiding this comment.
Web vitals measurements live on transaction events, not streamed spans, so those asserts are dropped rather than rewritten
Partially true. Web vitals are no longer collected on segment spans. But they are sent as separate spans. Can you check if we have other tests for Vue that directly assert on web vitals? If not, maybe we can assert on the web vital spans here. Or in a separate test in this app. Happy to leave it up to you.
Collaborator
Author
There was a problem hiding this comment.
Checked! no other Vue app asserts web vitals, only the test this PR deleted.
Added them back in 737e7e4
Web vitals are no longer collected on segment spans, but they are still sent: TTFB, FP and FCP as attributes on the pageload span, and LCP as a standalone `ui.webvital.lcp` span. The port dropped the old `measurements` asserts without replacing them, which left Vue with no web vitals coverage at all. Extends the root route pageload test to assert both, mirroring the already ported solid-tanstack-router app. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WQM2HA4xdirxTSCtQvDRP6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
traceLifecycle: 'static'pin from the Vue TanStack Router E2E app and rewrites the routing specs onto streamed spans.Why
Web vitals
measurementslive on transaction events, not streamed spans, so those asserts are dropped rather than rewritten. Route names stay/posts/$postId; the Vue SDK still usesurl.path.parameter.postId.Part of #23805