fix(remix): Strip trailing underscore from route segments - #24123
Merged
Conversation
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a25f13b. Configure here.
A trailing underscore in a Remix v2 flat route segment opts that segment out of layout nesting without appearing in the URL. Neither route-to-path converter handled it, so `routes/concerts_.mine` was named `/concerts_/mine` with source `route` - a high-confidence parameterized name matching no real URL. Strip one trailing underscore after the pathless-layout check and before the dynamic-segment handling, mirroring Remix's own createRoutePath. The ordering keeps `_auth_.login` a skipped layout and makes `$id_` resolve to `:id`. Fixes #24119 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
chargome
force-pushed
the
remix-trailing-underscore
branch
from
September 7, 2026 07:57
a25f13b to
9ae4652
Compare
Contributor
size-limit report 📦
|
chargome
marked this pull request as ready for review
September 7, 2026 08:07
chargome
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
September 7, 2026 08:07
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
nicohrubec
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A trailing underscore opts a Remix v2 route segment out of layout nesting without appearing in the URL, so
routes/concerts_.minewas named/concerts_/mine— with sourceroute, matching no real URL.Fixed in both converters (runtime naming and the build-time manifest). The strip runs after the pathless-layout check and before the dynamic-segment handling, mirroring Remix's
createRoutePath:_auth_.loginstays a skipped layout, and$id_resolves to:id.Fixes #24119