fix(core): Apply the sensitive denylist to cookie headers and configured fetch headers - #24090
Open
s1gr1d wants to merge 4 commits into
Open
fix(core): Apply the sensitive denylist to cookie headers and configured fetch headers#24090s1gr1d wants to merge 4 commits into
s1gr1d wants to merge 4 commits into
Conversation
…red fetch headers Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
s1gr1d
marked this pull request as ready for review
September 4, 2026 13:41
s1gr1d
requested review from
isaacs and
mydea
and removed request for
a team
September 4, 2026 13:41
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7ec524d. Configure here.
logaretm
reviewed
Sep 8, 2026
| */ | ||
| function parseCookieHeader(value: string, isSetCookie: boolean): Record<string, string> | undefined { | ||
| // Set-Cookie: single cookie with attributes ("name=value; HttpOnly; Secure") | ||
| // Cookie: multiple cookies separated by "; " ("cookie1=value1; cookie2=value2") |
Member
There was a problem hiding this comment.
m: The split is on '; ' (semicolon plus space), so a header without the space could still leak.
Cookie: theme=dark;__Secure-session=abc123
-> { 'http.request.header.cookie.theme': 'dark;__Secure-session=abc123' }
Could we use parseCookie and drop this function entirely? It seems to cover all the cases we need to support.
| // A non-empty string we cannot parse may still hold a session token, so it counts as sensitive. | ||
| if (Object.keys(parsed).length === 0) { | ||
| return {}; | ||
| return cookieString ? FILTERED : {}; |
Member
There was a problem hiding this comment.
l: This might be a no-op, both httpclient.ts call sites check for an object
const filtered = _INTERNAL_filterCookies(reqCookieStr, dc.cookies);
if (typeof filtered === 'object') {
requestCookies = filtered;
}So it would be dropped rather than show up as [FILTERED], maybe we need to adjust those checks as well?
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two ways a sensitive value slipped past the denylist.
A
Cookiesegment without an=became the attribute key itself, so ifCookie: <opaque-token>shipped the token ashttp.request.header.cookie.<opaque-token>. Those segments are dropped now, and a header with nothing extractable falls back to[Filtered], which is the documented behaviour.Headers listed in
headersToSpanAttributesskipped the denylist entirely, soauthorizationwent out in the clear. The spec says an allowlist never exempts a sensitive name, so those are filtered too.Fixes #24085