test(e2e): Port Solid E2E test apps to span streaming - #23940
Merged
msonnb merged 1 commit intoSep 2, 2026
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xo7LcmA5Cte2uiSmp7hXSN
Contributor
size-limit report 📦
|
andreiborza
approved these changes
Sep 2, 2026
msonnb
marked this pull request as ready for review
September 2, 2026 13:50
msonnb
deleted the
ms/js-3498-port-solid-e2e-test-apps-to-span-streaming
branch
September 2, 2026 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
solidandsolid-tanstack-routerto span streaming and addssolid-static, a verbatim copy ofsolidthat keepstraceLifecycle: 'static'and the transaction-based specs, so the static trace lifecycle stays covered.Under streaming, the plain
solidpageload span is namedPageloadwithsentry.segment.name.source: url, sincebrowserTracingIntegrationhas no route information. The error specs are unchanged: the scope's transaction name stays the URL path, so error events still carrytransaction: '/'.The web vitals spec in
solid-tanstack-routernow assertsbrowser.web_vital.{ttfb,fp,fcp}.valueattributes on the pageload span and a standaloneui.webvital.lcpspan, since measurements do not exist on streamed spans and LCP is reported as its own span on page hide.Closes: #23814