Skip to content

test(e2e): Port nextjs-16-cf-workers to span streaming - #23926

Merged
chargome merged 1 commit into
test/e2e-port-nextjs-16-bunfrom
test/e2e-port-nextjs-16-cf-workers
Sep 2, 2026
Merged

test(e2e): Port nextjs-16-cf-workers to span streaming#23926
chargome merged 1 commit into
test/e2e-port-nextjs-16-bunfrom
test/e2e-port-nextjs-16-cf-workers

Conversation

@chargome

@chargome chargome commented Sep 2, 2026

Copy link
Copy Markdown
Member

Ports nextjs-16-cf-workers to span streaming, completing the group: removes the traceLifecycle: 'static' pins and rewrites the specs onto streamed spans.

Most specs in this app are already test.skipped pending Cloudflare Workers SDK work; they are ported in place so they are span v2 when re-enabled. streaming-rsc-error is newly skipped - under streaming the Workers runtime emits no server segment span for a request interrupted by a streaming RSC error (#23932); the same spec passes on Node.

Ref #23802

@chargome chargome self-assigned this Sep 2, 2026
@linear-code

linear-code Bot commented Sep 2, 2026

Copy link
Copy Markdown

JS-3486

@chargome
chargome force-pushed the test/e2e-port-nextjs-16-cf-workers branch from 20ecf1b to 4c7c437 Compare September 2, 2026 11:18
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 28.57 kB - -
@sentry/browser - with treeshaking flags 26.94 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 26.83 kB - -
@sentry/browser (incl. Tracing) 48.87 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.88 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.8 kB - -
@sentry/browser (incl. Tracing, Replay) 88.36 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.76 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 93.05 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 106.02 kB - -
@sentry/browser (incl. Feedback) 46.06 kB - -
@sentry/browser (incl. sendFeedback) 33.64 kB - -
@sentry/browser (incl. FeedbackAsync) 38.74 kB - -
@sentry/browser (incl. Metrics) 29.52 kB - -
@sentry/browser (incl. Logs) 29.81 kB - -
@sentry/browser (incl. Metrics & Logs) 30.45 kB - -
@sentry/react 30.32 kB - -
@sentry/react (incl. Tracing) 51.08 kB - -
@sentry/vue 35.74 kB - -
@sentry/vue (incl. Tracing) 51.14 kB - -
@sentry/svelte 28.6 kB - -
CDN Bundle 30.36 kB - -
CDN Bundle (incl. Tracing) 49.52 kB - -
CDN Bundle (incl. Logs, Metrics) 32.59 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 51.43 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 73.19 kB - -
CDN Bundle (incl. Tracing, Replay) 87 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.88 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 92.93 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.83 kB - -
CDN Bundle - uncompressed 89.97 kB - -
CDN Bundle (incl. Tracing) - uncompressed 147.57 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 96.27 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 153.26 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 225.43 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 267.07 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 272.74 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 280.77 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 286.43 kB - -
@sentry/nextjs (client) 53.7 kB - -
@sentry/sveltekit (client) 49.3 kB - -
@sentry/core/server 40.74 kB - -
@sentry/core/browser 13.42 kB - -
@sentry/node 124.12 kB -0.07% -79 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 81.51 kB - -
@sentry/node - without tracing 88.3 kB +0.03% +21 B 🔺
@sentry/node - without channel injection 103.42 kB -0.08% -78 B 🔽
@sentry/aws-serverless 96.66 kB +0.03% +25 B 🔺
@sentry/cloudflare (withSentry) - minified 201.33 kB +0.26% +517 B 🔺
@sentry/cloudflare (withSentry) 501.09 kB +0.27% +1.33 kB 🔺

View base workflow run

Removes the `traceLifecycle: 'static'` pins and rewrites the specs onto streamed spans, completing the group.

Most of this app's specs are already `test.skip`ped pending Cloudflare Workers SDK work; those are ported in place so they are span v2 when re-enabled, and their TODO notes are kept verbatim.

`streaming-rsc-error` is newly skipped: under streaming the Workers runtime emits no server segment span for a request interrupted by a streaming RSC error, so the error-to-span correlation cannot be satisfied. The same spec passes on Node. See #23932

Like `nextjs-16-bun`, the parameterized-route specs assert fewer `url.*` attributes than `nextjs-16`, and request headers are not extracted as span attributes on Cloudflare Workers.

The middleware isolation-scope and breadcrumb assertions were dropped, having no span v2 equivalent.

Ref #23802
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@chargome
chargome force-pushed the test/e2e-port-nextjs-16-cf-workers branch from ece94e5 to e702483 Compare September 2, 2026 13:43
@chargome
chargome merged commit ef2c826 into develop Sep 2, 2026
291 checks passed
@chargome
chargome deleted the test/e2e-port-nextjs-16-cf-workers branch September 2, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants