test(e2e): Port nextjs-15 to span streaming - #23923
Draft
chargome wants to merge 1 commit into
Draft
Conversation
Contributor
size-limit report 📦
|
Removes the `traceLifecycle: 'static'` pins and rewrites the specs onto streamed spans. Tests asserting on children of a segment span use `collectStreamedSpans` and accumulate until the segment, which ends last. The RSC error specs correlate an error event with its server span. Those match the span on the error's own trace, so a span from an earlier spec cannot satisfy the correlation once streamed spans are flushed in batches. Request headers carry over as `http.request.header.*` span attributes, and the release as `sentry.release`, so the header-extraction and release-injection specs keep their coverage. The middleware specs asserted `request.url` / `request.method`; those become the `http.target` and `http.request.method` attributes. The `contexts.runtime.name === 'vercel-edge'` matcher was dropped, having no span v2 equivalent and only ever disambiguating a uniquely named span. Ref #23802 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
test/e2e-port-nextjs-15
branch
from
September 2, 2026 10:58
037e410 to
dd5edcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
nextjs-15to span streaming: removes thetraceLifecycle: 'static'pins and rewrites the specs onto streamed spans, usingcollectStreamedSpanswhere a test asserts on children of a segment span.The RSC error specs match the server span on the error event's own trace, so batching cannot pair spans across specs. Request headers carry over as
http.request.header.*attributes and the release assentry.release. Thecontexts.runtime.namematcher was dropped, having no span v2 equivalent.Ref https://linear.app/getsentry/issue/JS-3486/port-the-main-nextjs-e2e-test-suites-to-span-streaming
Ref #23802