test(e2e): Port the SolidStart E2E app to span streaming - #23917
Merged
Conversation
Contributor
size-limit report 📦
|
Removes the static trace lifecycle pin and rewrites the specs against streamed span v2. Server and db assertions collect children across envelopes; mysql spans are matched on db.query.text because both queries summarize to SELECT. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
The connection also emits SETINFO and INFO as db.query spans, so counting every db.query as the app's set/get pair fails. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
RulaKhaled
force-pushed
the
rolaabuhasna/js-3494/solidstart
branch
from
September 2, 2026 10:58
b809db3 to
e0f4da9
Compare
RulaKhaled
changed the base branch from
rolaabuhasna/js-3494/static-coverage
to
develop
September 2, 2026 11:00
RulaKhaled
marked this pull request as ready for review
September 2, 2026 11:52
andreiborza
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports
solidstartto span streaming.Why
Span streaming is the default now, so the E2E suite has to exercise it. Unparameterized
http.serverspans are named after the method alone, so pageload and db specs match the segment onurl.path. Mysql spans are named after the query summary, so both queries in that route come out asSELECTand are told apart bydb.query.text. Ioredis handshake commands (SETINFO,INFO) also show up asdb.queryspans, so the spec asserts only the app'sset/getpair.Part of #23810