test(e2e): Add a static trace lifecycle SolidStart E2E app - #23916
Draft
RulaKhaled wants to merge 1 commit into
Draft
test(e2e): Add a static trace lifecycle SolidStart E2E app#23916RulaKhaled wants to merge 1 commit into
RulaKhaled wants to merge 1 commit into
Conversation
Copies `solidstart` into `solidstart-static`, which keeps `traceLifecycle: 'static'` and its transaction-based specs. The rest of the SolidStart group moves to span streaming in the PRs above, so this copy is what keeps the static lifecycle covered. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
solidstart-static, a copy ofsolidstartthat keepstraceLifecycle: 'static'and its transaction-based specs.Why
The rest of the SolidStart E2E group is moving to span streaming in sibling PRs, so this copy is what keeps the static trace lifecycle covered.
solidstartis the representative because it is the only app in the group that exercises orchestrion db instrumentation (ioredis and mysql) on top of the shared client/server routing coverage.Being a verbatim copy, review bots flag pre-existing issues in it as if they were new. Those live in
solidstarton develop too and are better fixed in both apps separately.Part of #23810