feat(cloudflare)!: Skip rate limit spans - #23907
Merged
Merged
Conversation
JPeer264
requested review from
andreiborza,
isaacs,
mydea and
s1gr1d
and removed request for
a team,
isaacs and
mydea
September 2, 2026 08:54
andreiborza
reviewed
Sep 2, 2026
andreiborza
left a comment
andreiborza
left a comment
Member
There was a problem hiding this comment.
I'd rather fully remove the code instead of carrying it around commented. But maybe this could be an opt-in instead of hard-deciding to remove it for users?
Idk if anyone ever got values out of these so feel free to disregard the opt-in.
| import { instrumentQueueProducer } from './instrumentQueueProducer'; | ||
| import { instrumentR2Bucket } from './instrumentR2'; | ||
| import { instrumentRateLimit } from './instrumentRateLimit'; | ||
| // import { instrumentRateLimit } from './instrumentRateLimit'; |
Member
There was a problem hiding this comment.
q: why comment them out? Should just be removed imo.
Contributor
size-limit report 📦
|
Member
Author
Don't think so. I'd rather remove than making another option to opt into that |
andreiborza
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing rate limit spans. These spans didn't really give a great value rather than having more volume.
For the start of v11 we should remove them entirely and bring them back once we know how we can give proper value for that. I'll open a new ticket for it so we remember to re-add this functionality.
I don't suggest to re-add this at a later point as is, but maybe better. To only add spans when the rate limit actually hit, but this needs a little bit more thoughts and I think it's better to remove them at the start of v11 and re-add them later as feature with proper value.
The reason for this last minute change is that the update to v11 in the Sentry MCP added tons of low value spans, which we don't really need.
Also
rpcis the wrong OP, so this needs also fixingExample trace (these two spans didn't make sense, also
rpcis wrong):After an update the spans were doubled with only these spans: