Skip to content

test(e2e): Port nextjs-16-userfeedback to span streaming - #23867

Merged
chargome merged 1 commit into
test/e2e-cachecomponents-streaming-parityfrom
test/e2e-port-nextjs-16-userfeedback
Sep 2, 2026
Merged

test(e2e): Port nextjs-16-userfeedback to span streaming#23867
chargome merged 1 commit into
test/e2e-cachecomponents-streaming-parityfrom
test/e2e-port-nextjs-16-userfeedback

Conversation

@chargome

@chargome chargome commented Sep 1, 2026

Copy link
Copy Markdown
Member

Removes the traceLifecycle: 'static' pins from nextjs-16-userfeedback. Its specs assert on feedback and error envelopes, which streaming does not change, so no spec rewrite is needed.

Ref #23802

@chargome chargome self-assigned this Sep 1, 2026
@linear-code

linear-code Bot commented Sep 1, 2026

Copy link
Copy Markdown

JS-3486

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 28.57 kB - -
@sentry/browser - with treeshaking flags 26.94 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 26.83 kB - -
@sentry/browser (incl. Tracing) 48.87 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.88 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.8 kB - -
@sentry/browser (incl. Tracing, Replay) 88.36 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.76 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 93.05 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 106.02 kB - -
@sentry/browser (incl. Feedback) 46.06 kB - -
@sentry/browser (incl. sendFeedback) 33.64 kB - -
@sentry/browser (incl. FeedbackAsync) 38.74 kB - -
@sentry/browser (incl. Metrics) 29.52 kB - -
@sentry/browser (incl. Logs) 29.81 kB - -
@sentry/browser (incl. Metrics & Logs) 30.45 kB - -
@sentry/react 30.32 kB - -
@sentry/react (incl. Tracing) 51.08 kB - -
@sentry/vue 35.74 kB - -
@sentry/vue (incl. Tracing) 51.14 kB - -
@sentry/svelte 28.6 kB - -
CDN Bundle 30.36 kB - -
CDN Bundle (incl. Tracing) 49.52 kB +0.01% +1 B 🔺
CDN Bundle (incl. Logs, Metrics) 32.59 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 51.43 kB +0.01% +2 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 73.19 kB - -
CDN Bundle (incl. Tracing, Replay) 87 kB -0.01% -7 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.88 kB +0.01% +1 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 92.93 kB -0.02% -10 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.83 kB -0.01% -5 B 🔽
CDN Bundle - uncompressed 89.97 kB - -
CDN Bundle (incl. Tracing) - uncompressed 147.57 kB -0.01% -6 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed 96.27 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 153.26 kB -0.01% -6 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 225.43 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 267.07 kB -0.01% -6 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 272.74 kB -0.01% -6 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 280.77 kB -0.01% -6 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 286.43 kB -0.01% -6 B 🔽
@sentry/nextjs (client) 53.7 kB - -
@sentry/sveltekit (client) 49.3 kB - -
@sentry/core/server 40.74 kB - -
@sentry/core/browser 13.42 kB - -
@sentry/node 124.12 kB +0.09% +100 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 81.51 kB - -
@sentry/node - without tracing 88.3 kB +0.03% +22 B 🔺
@sentry/node - without channel injection 103.42 kB +0.09% +88 B 🔺
@sentry/aws-serverless 96.67 kB +0.04% +29 B 🔺
@sentry/cloudflare (withSentry) - minified 201.33 kB +0.05% +97 B 🔺
@sentry/cloudflare (withSentry) 501.09 kB +0.03% +149 B 🔺

View base workflow run

Removes the `traceLifecycle: 'static'` pins. The specs assert on feedback and error envelopes via `waitForEnvelopeItem`, which span streaming does not change, so no spec rewrite is needed.

Ref #23802
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@chargome
chargome force-pushed the test/e2e-port-nextjs-16-userfeedback branch from 850a896 to 22d729f Compare September 2, 2026 10:58
@chargome
chargome marked this pull request as ready for review September 2, 2026 12:51
@chargome
chargome merged commit e909f6e into develop Sep 2, 2026
853 of 881 checks passed
@chargome
chargome deleted the test/e2e-port-nextjs-16-userfeedback branch September 2, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants