test(e2e): Port the React Router instrumentation API E2E app to span streaming - #23845
Draft
andreiborza wants to merge 2 commits into
Draft
test(e2e): Port the React Router instrumentation API E2E app to span streaming#23845andreiborza wants to merge 2 commits into
andreiborza wants to merge 2 commits into
Conversation
Contributor
size-limit report 📦
|
andreiborza
force-pushed
the
ab/js-3482/instrumentation-api
branch
2 times, most recently
from
September 1, 2026 14:56
2f982ae to
a9e6808
Compare
andreiborza
force-pushed
the
ab/js-3482/instrumentation-api
branch
3 times, most recently
from
September 1, 2026 16:05
cf5c7f9 to
9e03698
Compare
andreiborza
force-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 1, 2026 16:37
9e03698 to
edd1076
Compare
…streaming Removes the `traceLifecycle: 'static'` pin from `react-router-7-framework-instrumentation` and rewrites its specs against streamed span v2. Loader, action, middleware and fetcher assertions now walk the streamed trace instead of a transaction's `spans` array. The orchestrion mysql spec matches on `db.query.text`, since a streamed mysql span is named after its query summary.
Left the fetcher test on collectStreamedSpans: it already scopes children by walking down from the fetcher span, and whether that span is a segment under streaming is not something to assume.
andreiborza
force-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 1, 2026 16:51
edd1076 to
7d44686
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7d44686. Configure here.
|
|
||
| const transactionEvent = await transactionEventPromise; | ||
| const spans = transactionEvent.spans || []; | ||
| const spans = await spansPromise; |
There was a problem hiding this comment.
Child span collection can flake
Medium Severity
collectStreamedTrace is used without an isDone predicate in tests that then assert on child spans. That helper resolves as soon as the segment arrives, and streamed children can flush after it, so loader, middleware, redis, and mysql assertions can fail even when the spans are later sent. The same PR already waits for those children in collectUntilSegment, and the sibling react-router-7-framework tests do too. This is flagged because the review rules call out races when waiting on telemetry that can arrive in arbitrary order, including in lazy.server.test.ts.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 7d44686. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports
react-router-7-framework-instrumentationto span streaming.Why
Span streaming is the default now, so the E2E suite has to exercise it. Loader, action, middleware and fetcher assertions walk the streamed trace instead of a transaction's
spansarray, and the orchestrion mysql spec matches ondb.query.text, since a streamed mysql span is named after its query summary.Part of #23798