test(e2e): Port React Router framework E2E apps to span streaming - #23844
Draft
andreiborza wants to merge 4 commits into
Draft
test(e2e): Port React Router framework E2E apps to span streaming#23844andreiborza wants to merge 4 commits into
andreiborza wants to merge 4 commits into
Conversation
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
andreiborza
force-pushed
the
ab/js-3482/framework-apps
branch
from
September 1, 2026 14:21
75dab6a to
ae51708
Compare
andreiborza
force-pushed
the
ab/js-3482/framework-apps
branch
2 times, most recently
from
September 1, 2026 16:05
47e95de to
5ecb95a
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5ecb95a. Configure here.
Removes the `traceLifecycle: 'static'` pin from `react-router-7-framework`, `react-router-8-framework` and `react-router-7-framework-spa`, and rewrites their specs against streamed span v2. Envelope-level metadata has no span equivalent, so the SDK assertions read the `sentry.sdk.*` and `sentry.environment` attributes instead, and the `runtime` tag assertions are dropped. The trace-connection spec matches the server segment on its op rather than its name, because an unparameterized streamed server span is named after the method alone.
Streamed spans are buffered for a few seconds before they flush, so an earlier page load's spans can still be arriving, and matching on op or URL alone paired the wrong halves. The document advertises its trace in the meta tag, so use that to select this page load's spans, and select the client span by the parent it continues so the trace assertion still fails when propagation breaks.
Streamed spans are buffered before they flush, so an earlier page load's query spans could end the wait early or fail the nesting check.
andreiborza
force-pushed
the
ab/js-3482/framework-apps
branch
from
September 1, 2026 16:51
54e87cd to
adf8c96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports
react-router-7-framework,react-router-8-frameworkandreact-router-7-framework-spato span streaming.Why
Span streaming is the default now, so the E2E suite has to exercise it. Envelope-level metadata has no span equivalent, so the SDK assertions read the
sentry.sdk.*andsentry.environmentattributes instead and theruntimetag assertions are dropped. The trace-connection spec matches the server segment on its op rather than its name, because an unparameterized streamed server span is named after the method alone.Part of #23798