test(e2e): Add a static trace lifecycle React Router E2E app - #23840
Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Lms24
approved these changes
Sep 1, 2026
chargome
approved these changes
Sep 1, 2026
andreiborza
force-pushed
the
ab/js-3482/static-coverage
branch
4 times, most recently
from
September 2, 2026 09:05
6817d85 to
d41e1c4
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d41e1c4. Configure here.
andreiborza
force-pushed
the
ab/js-3482/static-coverage
branch
from
September 2, 2026 09:30
d41e1c4 to
e83f714
Compare
andreiborza
changed the base branch from
develop
to
ab/js-3482/collect-streamed-spans
September 2, 2026 09:31
An error occurred while trying to automatically change base from
ab/js-3482/collect-streamed-spans
to
develop
September 2, 2026 09:57
andreiborza
force-pushed
the
ab/js-3482/static-coverage
branch
from
September 2, 2026 10:01
e83f714 to
3f2afd6
Compare
andreiborza
changed the base branch from
ab/js-3482/collect-streamed-spans
to
develop
September 2, 2026 10:01
Copies `react-router-7-framework` into `react-router-7-framework-static`, which keeps `traceLifecycle: 'static'` and its transaction-based specs. The rest of the React Router group moves to span streaming in the PRs above, so this copy is what keeps the static lifecycle covered. The copy drops the `latest` build variant, so it costs one CI job rather than two.
andreiborza
force-pushed
the
ab/js-3482/static-coverage
branch
from
September 2, 2026 10:07
3f2afd6 to
436f969
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
react-router-7-framework-static, a copy ofreact-router-7-frameworkthat keepstraceLifecycle: 'static'and its transaction-based specs.Why
The rest of the React Router E2E group moves to span streaming in the PRs above this one, so this copy is what keeps the static trace lifecycle covered. The issue suggested duplicating
react-19, butreact-router-7-frameworkis the app in this group with the most server and client instrumentation to keep covered. The copy drops thelatestbuild variant, so it costs one CI job rather than two.Being a verbatim copy, review bots flag pre-existing issues in it as if they were new. Those live in
react-router-7-frameworkon develop too and are better fixed in both apps separately.Part of #23798