test(e2e): Run DB driver tests against the dev server for the remaining frameworks - #23836
Open
chargome wants to merge 1 commit into
Open
test(e2e): Run DB driver tests against the dev server for the remaining frameworks#23836chargome wants to merge 1 commit into
chargome wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6d7b8ce. Configure here.
chargome
marked this pull request as ready for review
September 1, 2026 15:09
Base automatically changed from
chargome/fix/orchestrion-dev-server-instrumentation
to
develop
September 1, 2026 15:11
chargome
requested review from
mydea and
nicohrubec
and removed request for
a team
September 1, 2026 15:11
…ng frameworks Remix, Solid Start and TanStack Start only exercised orchestrion instrumentation against their production servers. Add a `TEST_ENV=development` pass over their DB tests so the runtime-hook path is covered too, the way astro-7, sveltekit-2 and react-router-7 already are. Solid Start and TanStack Start had no `dev` script, and neither dev server has build output to `--import`, so they load the SDK from the app's own instrumentation file instead. Solid Start needs a JS counterpart of its TypeScript init file for that. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWyZ1Vgti4W8q8sEuJsfEY
chargome
force-pushed
the
chargome/test/dev-e2e-remaining-frameworks
branch
from
September 1, 2026 15:13
6d7b8ce to
7375247
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remix, Solid Start and TanStack Start only ran their orchestrion DB tests against the production server. This adds dev versions to the e2e suites.
nuxt-4 stays out until the Nitro init-order defect from #23835 is fixed.