feat(deps): Bump find-up from 5.0.0 to 8.0.0 - #23703
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8d1fe08. Configure here.
| "@sentry/core": "10.67.0", | ||
| "dotenv": "^17.4.2", | ||
| "find-up": "^5.0.0", | ||
| "find-up": "^8.0.0", |
There was a problem hiding this comment.
find-up bump breaks existing API
High Severity
Bumping find-up from 5 to 8 leaves lookupPackageJson on the v5 default-export API. v6 switched to named exports (findUpSync, findUpStop) and v8 dropped the path-exists re-export (findUp.sync.exists). getPackageJson will fail on import or at runtime.
Reviewed by Cursor Bugbot for commit 8d1fe08. Configure here.
Bumps [find-up](https://github.com/sindresorhus/find-up) from 5.0.0 to 8.0.0. - [Release notes](https://github.com/sindresorhus/find-up/releases) - [Commits](sindresorhus/find-up@v5.0.0...v8.0.0) --- updated-dependencies: - dependency-name: find-up dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
8d1fe08 to
a024534
Compare
|
Superseded by #24112 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
…kup (#24112) ## What Drops the `find-up` dependency from `@sentry/bundler-plugins` and walks the directory tree directly in `lookupPackageJson`. Behavior is unchanged. ## Why `find-up` is pure ESM from v6 on, so dependabot's bump to v8 (#23703) breaks the CJS build of a package we publish. The plugin only used `find-up` to test whether a `package.json` exists and then walked the tree itself anyway, so a local loop removes the dependency and the interop risk at the same time. Supersedes #23703.


Bumps find-up from 5.0.0 to 8.0.0.
Release notes
Sourced from find-up's releases.
... (truncated)
Commits
5a009c28.0.0321107bRequire Node.js 2067f453cAddtype: 'both’option to find files or directories8e02916AddfindDownandfindDownSyncto search descendant directories (breadth-f...d65d145Stop re-exportingpath-exists(#69)f9d7aafMeta tweak6076472Minor tweak (#73)b733bb77.0.0187b2a1Require Node.js 18ba19153AcceptURLforstopAtoption