Skip to content

feat(deps): Bump find-up from 5.0.0 to 8.0.0 - #23703

Closed
dependabot[bot] wants to merge 1 commit into
developfrom
dependabot/npm_and_yarn/find-up-8.0.0
Closed

feat(deps): Bump find-up from 5.0.0 to 8.0.0#23703
dependabot[bot] wants to merge 1 commit into
developfrom
dependabot/npm_and_yarn/find-up-8.0.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 27, 2026

Copy link
Copy Markdown
Contributor

Bumps find-up from 5.0.0 to 8.0.0.

Release notes

Sourced from find-up's releases.

v8.0.0

Breaking

  • Require Node.js 20 321107b
  • Stop re-exporting path-exists (#69) d65d145
    • import it directly from its package.

Improvements

  • Add {type: 'both'} option to find files or directories 67f453c
  • Add findDown and findDownSync to search descendant directories 8e02916

sindresorhus/find-up@v7.0.0...v8.0.0

v7.0.0

Breaking

  • Require Node.js 18 187b2a1

Improvements

  • Accept URL for stopAt option ba19153

sindresorhus/find-up@v6.3.0...v7.0.0

v6.3.0

  • Accept URL as cwd (#60) f348f3c

sindresorhus/find-up@v6.2.0...v6.3.0

v6.2.0

sindresorhus/find-up@v6.1.0...v6.2.0

v6.1.0

sindresorhus/find-up@v6.0.0...v6.1.0

v6.0.0

Breaking

  • Require Node.js 12.20 e93cfd2
  • This package is now pure ESM. Please read this.
  • Changed from a default export to named exports.
    • const findUp = require('find-up') => import {findUp} from 'find-up'
    • const findUpSync = require('find-up').sync => import {findUpSync} from 'find-up'

... (truncated)

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Aug 27, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8d1fe08. Configure here.

"@sentry/core": "10.67.0",
"dotenv": "^17.4.2",
"find-up": "^5.0.0",
"find-up": "^8.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find-up bump breaks existing API

High Severity

Bumping find-up from 5 to 8 leaves lookupPackageJson on the v5 default-export API. v6 switched to named exports (findUpSync, findUpStop) and v8 dropped the path-exists re-export (findUp.sync.exists). getPackageJson will fail on import or at runtime.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8d1fe08. Configure here.

Bumps [find-up](https://github.com/sindresorhus/find-up) from 5.0.0 to 8.0.0.
- [Release notes](https://github.com/sindresorhus/find-up/releases)
- [Commits](sindresorhus/find-up@v5.0.0...v8.0.0)

---
updated-dependencies:
- dependency-name: find-up
  dependency-version: 8.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@andreiborza

Copy link
Copy Markdown
Member

Superseded by #24112

@andreiborza andreiborza closed this Sep 4, 2026
@dependabot @github

dependabot Bot commented on behalf of github Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/find-up-8.0.0 branch September 4, 2026 15:11
andreiborza added a commit that referenced this pull request Sep 4, 2026
…kup (#24112)

## What

Drops the `find-up` dependency from `@sentry/bundler-plugins` and walks
the directory tree directly in `lookupPackageJson`. Behavior is
unchanged.

## Why

`find-up` is pure ESM from v6 on, so dependabot's bump to v8 (#23703)
breaks the CJS build of a package we publish. The plugin only used
`find-up` to test whether a `package.json` exists and then walked the
tree itself anyway, so a local loop removes the dependency and the
interop risk at the same time. Supersedes #23703.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant