feat(server-utils): Emit low cardinality knex, tedious and prisma db span names - #23602
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Lms24
changed the title
Lms24
force-pushed
the
lms/feat-server-utils-low-card-db-span-names3
branch
from
August 28, 2026 10:58
acc75d0 to
340500e
Compare
Lms24
marked this pull request as ready for review
August 28, 2026 11:26
Lms24
requested review from
JPeer264 and
isaacs
and removed request for
a team
August 28, 2026 11:26
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
isaacs
reviewed
Aug 30, 2026
isaacs
left a comment
isaacs
left a comment
Member
There was a problem hiding this comment.
This mostly LGTM, with some minor comments. The only concern I'd really worry about is to merge in the upstream and make sure that we're setting the dialect when sanitizing the SQL query.
Lms24
force-pushed
the
lms/feat-server-utils-low-card-db-span-names3
branch
from
August 31, 2026 09:04
0e97042 to
97f126b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 97f126b. Configure here.
Lms24
force-pushed
the
lms/feat-server-utils-low-card-db-span-names3
branch
from
September 1, 2026 07:44
97f126b to
428c3bf
Compare
isaacs
self-requested a review
September 2, 2026 03:29
… span names
With span streaming, these three name their query spans from the span name
conventions instead of the SQL statement. They are grouped because each needs a
different fallback: knex drops to its existing `{operation} {namespace}.{table}`,
tedious has no statement to summarize and keeps `getSpanName`, and prisma resolves
its statement from either `db.statement` or `db.query.text` depending on version.
knex and prisma also report the new `db.query.summary` attribute.
`traceLifecycle: 'static'` keeps the existing names.
Refs #23523
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…v7 streaming test The Prisma v7 span-streaming test filtered query spans on `auto.db.otel.prisma`, which #23627 renamed to `auto.db.prisma`. The filter matched nothing, so the assertion threw — and because the test runs `.unordered()`, `newEnvelope` swallows assertion errors and keeps waiting for another envelope, turning it into an opaque 75s timeout rather than a diff. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
lms/feat-server-utils-low-card-db-span-names3
branch
from
September 2, 2026 07:18
428c3bf to
2ac512a
Compare
JPeer264
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With span streaming enabled:
db.query.summary, with fallbacks according to lower prio sentry convention name templatestraceLifecycle: 'static'keeps the existing namesAlso discovered some bugs along the way that should be addressed afterwards but don't belong into this PR:
Refs #23523