feat(aws-serverless): Use orchestrion aws-sdk integration under diagnostics-channel opt-in#22143
Draft
andreiborza wants to merge 2 commits into
Draft
feat(aws-serverless): Use orchestrion aws-sdk integration under diagnostics-channel opt-in#22143andreiborza wants to merge 2 commits into
andreiborza wants to merge 2 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
andreiborza
force-pushed
the
ab/aws-sdk-server-utils
branch
from
6b85478 to
ca51438
Compare
andreiborza
changed the base branch from
ab/aws-sdk-server-utils
to
ab/aws-sdk-messaging
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
2 times, most recently
from
bdc838e to
9297436
Compare
andreiborza
force-pushed
the
ab/aws-sdk-messaging
branch
from
5069f36 to
6abbb22
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
9297436 to
31816fd
Compare
andreiborza
force-pushed
the
ab/aws-sdk-messaging
branch
2 times, most recently
from
1964abf to
f024586
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
2 times, most recently
from
0b89e37 to
a3978fa
Compare
andreiborza
force-pushed
the
ab/aws-sdk-messaging
branch
from
f024586 to
430affd
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a3978fa. Configure here.
andreiborza
force-pushed
the
ab/aws-sdk-messaging
branch
from
430affd to
d26e97f
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
a3978fa to
809da29
Compare
andreiborza
force-pushed
the
ab/aws-sdk-messaging
branch
from
d26e97f to
711b9bd
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
809da29 to
8907ff9
Compare
andreiborza
force-pushed
the
ab/aws-sdk-messaging
branch
from
711b9bd to
3f1cf4a
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
8907ff9 to
c0e10d6
Compare
andreiborza
force-pushed
the
ab/aws-sdk-messaging
branch
from
3f1cf4a to
c43b14c
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
c0e10d6 to
561e41b
Compare
andreiborza
force-pushed
the
ab/aws-sdk-messaging
branch
from
c43b14c to
d993b9e
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
561e41b to
8ffb46b
Compare
…ostics-channel opt-in Wires the orchestrion aws-sdk channel integration into `@sentry/aws-serverless`, where the OTel `Aws` integration ships as a default today. `@sentry/node` exposes a reusable `applyDiagnosticsChannelInjectionIntegrations` helper (extracted from its `getDefaultIntegrations`), and `@sentry/aws-serverless` uses it to swap the OTel `Aws` integration for the channel version when the app opts in via `experimentalUseDiagnosticsChannelInjection()` (now re-exported from the aws-serverless SDK). No change when the opt-in isn't used. The existing `aws-integration` node-integration-tests assert the swapped origin via `isOrchestrionEnabled()`, so both the OTel and diagnostics-channel paths are covered by the same suites across both smithy stacks and ESM/CJS. Part of #20946 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/aws-sdk-messaging
branch
from
d993b9e to
c2cad25
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
8ffb46b to
556da6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the orchestrion aws-sdk channel integration into
@sentry/aws-serverless, where the OTelAwsintegration ships as a default today.@sentry/nodeexposes a reusableapplyDiagnosticsChannelInjectionIntegrationshelper (extracted from itsgetDefaultIntegrations), and@sentry/aws-serverlessuses it to swap the OTelAwsintegration for the channel version when the app opts in viaexperimentalUseDiagnosticsChannelInjection()(now re-exported from the aws-serverless SDK). No change when the opt-in isn't used.The existing
aws-integrationnode-integration-tests assert the swapped origin viaisOrchestrionEnabled(), so both the OTel and diagnostics-channel paths are covered by the same suites across both smithy stacks (latest + legacy3.1041.0) and ESM/CJS. Only the expected origin is parametrized.Part of #20946