-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
add gen_ai.request.messages.original_length attributes #18608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
isaacs
wants to merge
1
commit into
develop
Choose a base branch
from
isaacschlueter/js-1350-record-gen_airequestmessagesoriginal_length-in-javascript
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add gen_ai.request.messages.original_length attributes #18608
isaacs
wants to merge
1
commit into
develop
from
isaacschlueter/js-1350-record-gen_airequestmessagesoriginal_length-in-javascript
+155
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
486353c to
3d2dca5
Compare
isaacs
added a commit
that referenced
this pull request
Dec 22, 2025
…18608) Whenever the `gen_ai.request.messages` is potentially truncated, add a `gen_ai.request.messages.original_length` attribute indicating the initial length of the array, so that the truncation is evident. Closes JS-1350
7da9214 to
66f4025
Compare
isaacs
added a commit
that referenced
this pull request
Dec 22, 2025
…18608) Whenever the `gen_ai.request.messages` is potentially truncated, add a `gen_ai.request.messages.original_length` attribute indicating the initial length of the array, so that the truncation is evident. Closes JS-1350
66f4025 to
6e03da3
Compare
isaacs
added a commit
that referenced
this pull request
Dec 22, 2025
…18608) Whenever the `gen_ai.request.messages` is potentially truncated, add a `gen_ai.request.messages.original_length` attribute indicating the initial length of the array, so that the truncation is evident. Closes JS-1350
6e03da3 to
415585d
Compare
isaacs
added a commit
that referenced
this pull request
Dec 22, 2025
…18608) Whenever the `gen_ai.request.messages` is potentially truncated, add a `gen_ai.request.messages.original_length` attribute indicating the initial length of the array, so that the truncation is evident. Closes JS-1350
415585d to
b964f0d
Compare
RulaKhaled
reviewed
Jan 5, 2026
Member
RulaKhaled
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, I left small comments
isaacs
added a commit
that referenced
this pull request
Jan 6, 2026
…18608) Whenever the `gen_ai.request.messages` is potentially truncated, add a `gen_ai.request.messages.original_length` attribute indicating the initial length of the array, so that the truncation is evident. Closes JS-1350
b964f0d to
5f94ce9
Compare
isaacs
added a commit
that referenced
this pull request
Jan 6, 2026
isaacs
added a commit
that referenced
this pull request
Jan 6, 2026
…18608) Whenever the `gen_ai.request.messages` is potentially truncated, add a `gen_ai.request.messages.original_length` attribute indicating the initial length of the array, so that the truncation is evident. Closes JS-1350
isaacs
added a commit
that referenced
this pull request
Jan 6, 2026
isaacs
added a commit
that referenced
this pull request
Jan 6, 2026
91d32d9 to
10ae833
Compare
isaacs
added a commit
that referenced
this pull request
Jan 6, 2026
10ae833 to
f7f1e24
Compare
…18608) Whenever the `gen_ai.request.messages` is potentially truncated, add a `gen_ai.request.messages.original_length` attribute indicating the initial length of the array, so that the truncation is evident. Closes JS-1350
f7f1e24 to
1006f2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the
gen_ai.request.messagesis potentially truncated, add agen_ai.request.messages.original_lengthattribute indicating theinitial length of the array, so that the truncation is evident.
Closes JS-1350