[skill-drift] fix(sentry-cocoa-sdk): app start limit + SentryObjC docs#149
Open
github-actions[bot] wants to merge 1 commit into
Conversation
Automated drift-fix run. Co-Authored-By: Claude (claude-sonnet-4-5) <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| | Initial Frame Render | `didFinishLaunchingNotification` → first CADisplayLink callback (v9+) | | ||
|
|
||
| > Warning: If more than **5 seconds** elapse between transaction start and app-start end, app start spans are **not attached** to avoid misassociation. This limit is skipped when standalone app start tracing is enabled. | ||
| > Warning: If more than **180 seconds** (3 minutes) elapse between transaction start and app-start end, app start spans are **not attached** to avoid misassociation. This limit is skipped when standalone app start tracing is enabled. |
There was a problem hiding this comment.
Bug: The documentation for the app start duration threshold is inconsistent. The warning note states a 180-second limit, but the troubleshooting table still refers to the old 5-second limit.
Severity: LOW
Suggested Fix
Update the troubleshooting table in skills/sentry-cocoa-sdk/references/tracing.md to reflect the new 180-second threshold. Change the text "exceeded 5 seconds" to "exceeded 180 seconds" to align with the updated warning note.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: skills/sentry-cocoa-sdk/references/tracing.md#L169
Potential issue: The documentation in `skills/sentry-cocoa-sdk/references/tracing.md`
contains conflicting information regarding the app start duration threshold. While the
warning note on line 169 was updated by this pull request to state a 180-second limit, a
troubleshooting table at the end of the same file was not updated and still references
the old 5-second limit. This inconsistency can lead to confusion for developers or AI
models consulting the documentation, as they might receive incorrect guidance when
diagnosing why app start spans are not being attached.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Auto-generated from external SDK content. Review all links and code suggestions before acting on them.
Summary
Changes
1. App Start Duration Limit Fix
File:
skills/sentry-cocoa-sdk/references/tracing.mdCorrected the maximum app start duration from "5 seconds" to "180 seconds (3 minutes)" to match the actual SDK implementation (
SentryAppStartTracker.maxAppStartDuration = 180.0). The warning note correctly stated that this limit is skipped for standalone app start tracing.2. SentryObjC Documentation
File:
skills/sentry-cocoa-sdk/SKILL.mdAdded Option 4 documenting the new experimental SentryObjC wrapper SDK. This is for pure Objective-C/C++ projects that cannot enable Clang modules (e.g., with
-fmodules=NO). The documentation includes:PRs Reviewed
Verification
SentryAppStartTracker.swiftsource at merge SHA bbb8fdc7Source PRs