Skip to content

feat!: Raise minimum supported Electron to v35 #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timfish wants to merge 1 commit into from
+13 −5
Closed

feat!: Raise minimum supported Electron to v35 #1423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions MIGRATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,18 @@
This document details the changes between major versions of the Sentry Electron
SDK.

- [Upgrading from 7.x to 8.x](#upgrading-from-7x-to-8x)
- [Upgrading from 6.x to 7.x](#upgrading-from-6x-to-7x)
- [Upgrading from 5.x to 6.x](#upgrading-from-5x-to-6x)
- [Upgrading from 4.x to 5.x](#upgrading-from-4x-to-5x)

# Upgrading from 7.x to 8.x

## Supported Electron Versions

The Sentry Node SDK now requires Node >= 20.19.0 which means the Sentry Electron
SDK now supports Electron >= 35.0.0.

# Upgrading from 6.x to 7.x

Most users won't notice many breaking API changes in v7 but it's worth checking
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Test](https://github.com/getsentry/sentry-electron/actions/workflows/build.yml/b
[`@sentry/browser`](https://github.com/getsentry/sentry-javascript/tree/master/packages/browser))
- Captures **native crashes** (Minidump crash reports) from renderers and the main process
- Collects **breadcrumbs and context** information along with events across renderers and the main process
- Supports `electron >= v23`
- Supports `electron >= v35`

## Usage

Expand Down
2 changes: 1 addition & 1 deletion scripts/update-electron-versions.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const result = spawnSync('npm', ['view', 'electron', 'dist-tags', '--json'], { e
const allTags = JSON.parse(result.stdout);

const versions = [];
let startVersion = 23;
let startVersion = 35;

while (true) {
const versionTag = `${startVersion}-x-y`;
Expand Down
4 changes: 2 additions & 2 deletions src/main/sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ export type ElectronMainOptions = Pick<
export function init(userOptions: ElectronMainOptions): void {
const [major = 0] = process.versions.electron.split('.').map(Number);

if (major < 23) {
throw new Error('Sentry Electron SDK requires Electron 23 or higher');
if (major < 35) {
throw new Error('Sentry Electron SDK requires Electron 35 or higher');
}

const inferIpAddress = userOptions.dataCollection?.userInfo ?? true;
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
["23.3.13","24.8.8","25.9.8","26.6.10","27.3.11","28.3.3","29.4.6","30.5.1","31.7.7","32.3.3","33.4.11","34.5.8","35.7.5","36.9.5","37.10.3","38.8.6","39.8.10","40.10.6","41.10.7","42.11.0","43.5.0","44.1.0"]
["35.7.5","36.9.5","37.10.3","38.8.6","39.8.10","40.10.6","41.10.7","42.11.0","43.5.0","44.1.0"]
Loading