Skip to content

fix(ci): cap release e2e matrix to stay under GitHub's 256 limit #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timfish merged 1 commit into from
Sep 1, 2026
Merged

fix(ci): cap release e2e matrix to stay under GitHub's 256 limit #1420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions scripts/e2e-test-versions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,26 @@ const { readFileSync } = require('fs');

const versions = JSON.parse(readFileSync('./test/e2e/versions.json', 'utf8'));

// GitHub Actions limits a job matrix to 256 configurations. The e2e matrix
// multiplies each Electron version by 3 operating systems and 4 shards (12),
// so we can test at most floor(256 / 12) = 21 Electron versions.
const MAX_VERSIONS = 21;

// Always test the oldest supported version, then fill the remaining budget with
// the newest versions.
function selectVersions(count) {
if (versions.length <= count) {
return versions;
}
return [...new Set([versions[0], ...versions.slice(versions.length - (count - 1))])];
}

if (process.env.GITHUB_REF && process.env.GITHUB_REF.includes('release/')) {
// For release builds we test all versions
console.log(JSON.stringify(versions));
// For release builds we test the oldest supported version and as many of the
// newest versions as the matrix limit allows.
console.log(JSON.stringify(selectVersions(MAX_VERSIONS)));
} else {
const versionCount = process.platform === 'darwin' ? -3 : -7;
// Otherwise we test the oldest supported version and the last 3 or 7 versions depending on the platform
console.log(JSON.stringify([versions[0], ...versions.slice(versionCount)]));
const versionCount = process.platform === 'darwin' ? 3 : 7;
console.log(JSON.stringify(selectVersions(versionCount + 1)));
}
Loading