fix: [.NET 10] PageNavigationExtensions updated for public Page properties#5278
Open
nor0x wants to merge 3 commits into
Open
fix: [.NET 10] PageNavigationExtensions updated for public Page properties#5278nor0x wants to merge 3 commits into
nor0x wants to merge 3 commits into
Conversation
starting with .NET 10 DestinationPage and PreviousPage in NavigatedFromEventArgs and NavigatedToEventArgs are no longer internal so no need for getting them via reflection in PageNavigationExtensions. see: getsentry#4578 and: dotnet/maui#28384
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8d5b5ee. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
starting with .NET 10
DestinationPageandPreviousPageinNavigatedFromEventArgsandNavigatedToEventArgsare no longer internal so no need for getting them via reflection inPageNavigationExtensions.PR in dotnet/maui: dotnet/maui#28384
fixes: #4578