Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/product/stats/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ Events and attachments discarded by the SDK. The following reasons are currently
- **Invalid**: An event was dropped because it contained invalid data (e.g. replay session exceeded maximum allowed length).
- **Ignored**: An event was ignored by the SDK (for example, a span was ignored by `ignore_spans`).
- **No Parent Span**: A span was not started or dropped because no parent span was present at span start (for example, auto-instrumented request spans suppressed when the request happens outside an active span).
- **Callback Error**: An event was dropped because a callback (e.g., `before_send`, `traces_sampler`) threw an error.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The new discard reason callback_error was added to product docs but is missing from the authoritative SDK specification, creating an inconsistency for implementers.
Severity: LOW

Suggested Fix

Update the discard reasons table in develop-docs/sdk/telemetry/client-reports.mdx to include the new callback_error reason. Also, add an entry to the spec's changelog to reflect this addition, ensuring consistency between the product docs and the SDK specification.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: docs/product/stats/index.mdx#L99

Potential issue: The pull request adds the `callback_error` discard reason to the
user-facing product documentation. However, it fails to update the authoritative SDK
specification located at `develop-docs/sdk/telemetry/client-reports.mdx`. This violates
the documented process for adding new discard reasons, which requires updating the spec
first. This inconsistency can cause confusion for SDK implementers who rely on the
specification to understand valid discard reasons and may not implement reporting for
`callback_error`.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be done in #19218


For more details, please consult the [Client Reports](https://develop.sentry.dev/sdk/telemetry/client-reports/#envelope-item-payload) documentation.

Expand Down
Loading